Skip to content

Resolve Go Module Name Discrepancies #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danehans opened this issue Feb 10, 2025 · 2 comments · Fixed by #318
Closed

Resolve Go Module Name Discrepancies #316

danehans opened this issue Feb 10, 2025 · 2 comments · Fixed by #318
Assignees
Milestone

Comments

@danehans
Copy link
Contributor

Gateway API module name: sigs.k8s.io/gateway-api
Inference Extension module name: inference.networking.x-k8s.io/gateway-api-inference-extension

Why do these differ? Having a common naming scheme between the projects simplifies the implementation for implementors.

@robscott
Copy link
Member

Good point, this seems like a mistake. While we want the CRDs to be part of inference.networking.x-k8s.io, that should be entirely disconnected from the go module name.

@danehans
Copy link
Contributor Author

I worked around the issue with a replace directive in my project's go.mod:

replace inference.networking.x-k8s.io/gateway-api-inference-extension => ../../../sigs.k8s.io/gateway-api-inference-extension

This will need to be resolved before v0.2.0.

@danehans danehans changed the title Reconcile Go Module Name Differences Resolve Go Module Name Discrepancies Feb 10, 2025
@danehans danehans self-assigned this Feb 10, 2025
@danehans danehans added this to the v0.2.0-rc.1 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants