Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lora-syncer tool's error handling needs improvement #584

Open
kfswain opened this issue Mar 26, 2025 · 0 comments
Open

lora-syncer tool's error handling needs improvement #584

kfswain opened this issue Mar 26, 2025 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kfswain
Copy link
Collaborator

kfswain commented Mar 26, 2025

What happened: lora was unable to be loaded to vLLM, and the lora syncer emitted Red Herring error logs and kept retrying the same adapter, blocking other, valid adapters

What you expected to happen: fail to load an adapter gracefully, and move on to the next one in the list

How to reproduce it (as minimally and precisely as possible): configure 2 lora adapters, 1 valid rank 8 adapter, and one invalid adapter (vllm default max rank is 16, so choose larger than that), apply.

@kfswain kfswain added the kind/bug Categorizes issue or PR as related to a bug. label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant