Skip to content

Add a generic AddPlugin option to configure the scheduler #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
liu-cong opened this issue May 9, 2025 · 2 comments · May be fixed by #835
Open

Add a generic AddPlugin option to configure the scheduler #813

liu-cong opened this issue May 9, 2025 · 2 comments · May be fixed by #835
Assignees
@liu-cong @nirrozenbaum
Labels
needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@liu-cong
Copy link
Contributor

liu-cong commented May 9, 2025

What would you like to be added:

An AddPlugin implemented as a type ConfigOption func(*SchedulerConfig) that uses reflection to check which extension points the plugin implements, and add those extension points to the config.

This should also deprecate any existing helper functions to add plugins, such as AddPrefixPlugin

Why is this needed:

This is a follow up to the discussion in #768 (review)
@liu-cong liu-cong added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 9, 2025
@liu-cong liu-cong mentioned this issue May 9, 2025
Merged
@liu-cong
Copy link
Contributor Author

liu-cong commented May 9, 2025

/assign

@nirrozenbaum
Copy link
Contributor

/assign
(coordinated with @liu-cong)

@nirrozenbaum nirrozenbaum linked a pull request May 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liu-cong liu-cong

@nirrozenbaum nirrozenbaum

Labels
needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
2 participants
@liu-cong @nirrozenbaum