From 5458652fe9e4fe9e3739036f358cc65b3dc50b0e Mon Sep 17 00:00:00 2001 From: Kellen Swain Date: Fri, 14 Mar 2025 20:17:22 +0000 Subject: [PATCH] Fixing image build and adding image building to test runs --- Dockerfile | 2 +- Makefile | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index 312700bc..8fb00dfb 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,6 +1,6 @@ # Dockerfile has specific requirement to put this ARG at the beginning: # https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact -ARG BUILDER_IMAGE=golang:1.23 +ARG BUILDER_IMAGE=golang:1.24 ARG BASE_IMAGE=gcr.io/distroless/static:nonroot ## Multistage build diff --git a/Makefile b/Makefile index c3c24892..0a02cb9c 100644 --- a/Makefile +++ b/Makefile @@ -44,7 +44,7 @@ BBR_IMAGE_REPO ?= $(IMAGE_REGISTRY)/$(BBR_IMAGE_NAME) BBR_IMAGE_TAG ?= $(BBR_IMAGE_REPO):$(GIT_TAG) BASE_IMAGE ?= gcr.io/distroless/static:nonroot -BUILDER_IMAGE ?= golang:1.23 +BUILDER_IMAGE ?= golang:1.24 ifdef GO_VERSION BUILDER_IMAGE = golang:$(GO_VERSION) endif @@ -120,7 +120,7 @@ vet: ## Run go vet against code. go vet ./... .PHONY: test -test: manifests generate fmt vet envtest ## Run tests. +test: manifests generate fmt vet envtest image-build ## Run tests. KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test $$(go list ./... | grep -v /e2e) -race -coverprofile cover.out .PHONY: test-integration