Skip to content

Commit 225fc80

Browse files
committed
don't override global timeout when making HTTP requests
1 parent a6e3183 commit 225fc80

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

conformance/tests/gateway-dynamic-listeners.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,6 @@ var GatewayListenerHTTPRouteDynamicPorts = suite.ConformanceTest{
179179
require.NoErrorf(t, err, "timed out waiting for Gateway address to be assigned")
180180

181181
for _, listener := range mutate.Spec.Listeners {
182-
timeoutConfig := s.TimeoutConfig
183-
// TODO - It takes much longer for listeners to be consistent
184-
if timeoutConfig.MaxTimeToConsistency < timeoutConfig.GatewayStatusMustHaveListeners {
185-
timeoutConfig.MaxTimeToConsistency = timeoutConfig.GatewayStatusMustHaveListeners
186-
}
187182
host, _, err := net.SplitHostPort(gwAddr)
188183
require.NoErrorf(t, err, "unable to split gateway address %q", gwAddr)
189184

@@ -198,9 +193,9 @@ var GatewayListenerHTTPRouteDynamicPorts = suite.ConformanceTest{
198193
if listener.TLS != nil {
199194
host := string(*listener.Hostname)
200195
expectedResponse.Request.Host = host
201-
tls.MakeTLSRequestAndExpectEventuallyConsistentResponse(t, s.RoundTripper, timeoutConfig, addr, certBytes, keyBytes, host, expectedResponse)
196+
tls.MakeTLSRequestAndExpectEventuallyConsistentResponse(t, s.RoundTripper, s.TimeoutConfig, addr, certBytes, keyBytes, host, expectedResponse)
202197
} else {
203-
http.MakeRequestAndExpectEventuallyConsistentResponse(t, s.RoundTripper, timeoutConfig, addr, expectedResponse)
198+
http.MakeRequestAndExpectEventuallyConsistentResponse(t, s.RoundTripper, s.TimeoutConfig, addr, expectedResponse)
204199
}
205200

206201
}

0 commit comments

Comments
 (0)