Webhook: Validate unique port, protocol per hostname for gateway listeners

Signed-off-by: Huang Xin <[email protected]>

Author: gyohuangxin

apis/v1beta1/validation/gateway.go

@@ -62,6 +62,8 @@ func validateGatewayListeners(listeners []gatewayv1b1.Listener, path *field.Path
 	var errs field.ErrorList
 	errs = append(errs, validateListenerTLSConfig(listeners, path)...)
 	errs = append(errs, validateListenerHostname(listeners, path)...)
+	errs = append(errs, validateUniqueProtocol(listeners, path)...)
+	errs = append(errs, validateUniquePort(listeners, path)...)
 	return errs
 }
 
@@ -91,3 +93,57 @@ func validateListenerHostname(listeners []gatewayv1b1.Listener, path *field.Path
 	}
 	return errs
 }
+
+// validateUniqueProtocol validates each listener hostname
+// should not have the duplicate protocols
+func validateUniqueProtocol(listeners []gatewayv1b1.Listener, path *field.Path) field.ErrorList {
+	var errs field.ErrorList
+	hostnameProtocolUnique := make(map[gatewayv1b1.Hostname]map[gatewayv1b1.ProtocolType]int)
+	for i, h := range listeners {
+		if h.Hostname == nil {
+			continue
+		}
+		if len(hostnameProtocolUnique) == 0 {
+			hostnameProtocolUnique[*h.Hostname] = map[gatewayv1b1.ProtocolType]int{h.Protocol: i}
+			continue
+		}
+		if _, hostnameFound := hostnameProtocolUnique[*h.Hostname]; hostnameFound {
+			if _, protocolFound := hostnameProtocolUnique[*h.Hostname][h.Protocol]; protocolFound {
+				errs = append(errs, field.Forbidden(path.Index(i).Child("protocol"), fmt.Sprintf("should be unique in hostname: %v", *h.Hostname)))
+				return errs
+			} else {
+				hostnameProtocolUnique[*h.Hostname][h.Protocol] = i
+			}
+		} else {
+			hostnameProtocolUnique[*h.Hostname] = map[gatewayv1b1.ProtocolType]int{h.Protocol: i}
+		}
+	}
+	return errs
+}
+
+// validateUniquePort validates each listener hostname
+// should not have the duplicate ports
+func validateUniquePort(listeners []gatewayv1b1.Listener, path *field.Path) field.ErrorList {
+	var errs field.ErrorList
+	hostnamePortUnique := make(map[gatewayv1b1.Hostname]map[gatewayv1b1.PortNumber]int)
+	for i, h := range listeners {
+		if h.Hostname == nil {
+			continue
+		}
+		if len(hostnamePortUnique) == 0 {
+			hostnamePortUnique[*h.Hostname] = map[gatewayv1b1.PortNumber]int{h.Port: i}
+			continue
+		}
+		if _, hostnameFound := hostnamePortUnique[*h.Hostname]; hostnameFound {
+			if _, portFound := hostnamePortUnique[*h.Hostname][h.Port]; portFound {
+				errs = append(errs, field.Forbidden(path.Index(i).Child("port"), fmt.Sprintf("should be unique in hostname: %v", *h.Hostname)))
+				return errs
+			} else {
+				hostnamePortUnique[*h.Hostname][h.Port] = i
+			}
+		} else {
+			hostnamePortUnique[*h.Hostname] = map[gatewayv1b1.PortNumber]int{h.Port: i}
+		}
+	}
+	return errs
+}

apis/v1beta1/validation/gateway_test.go

@@ -29,6 +29,9 @@ func TestValidateGateway(t *testing.T) {
 		{
 			Hostname: nil,
 		},
+		{
+			Hostname: nil,
+		},
 	}
 	addresses := []gatewayv1b1.GatewayAddress{
 		{
@@ -82,6 +85,30 @@ func TestValidateGateway(t *testing.T) {
 			},
 			expectErrsOnFields: []string{"spec.listeners[0].hostname"},
 		},
+		"protocal is not unique in hostname": {
+			mutate: func(gw *gatewayv1b1.Gateway) {
+				hostname := gatewayv1b1.Hostname("foo.bar.com")
+				gw.Spec.Listeners[0].Hostname = &hostname
+				gw.Spec.Listeners[0].Protocol = gatewayv1b1.HTTPProtocolType
+				gw.Spec.Listeners[0].Port = gatewayv1b1.PortNumber(80)
+				gw.Spec.Listeners[1].Hostname = &hostname
+				gw.Spec.Listeners[1].Protocol = gatewayv1b1.HTTPProtocolType
+				gw.Spec.Listeners[1].Port = gatewayv1b1.PortNumber(81)
+			},
+			expectErrsOnFields: []string{"spec.listeners[1].protocol"},
+		},
+		"port is not unique in hostname": {
+			mutate: func(gw *gatewayv1b1.Gateway) {
+				hostname := gatewayv1b1.Hostname("foo.bar.com")
+				gw.Spec.Listeners[0].Hostname = &hostname
+				gw.Spec.Listeners[0].Protocol = gatewayv1b1.HTTPProtocolType
+				gw.Spec.Listeners[0].Port = gatewayv1b1.PortNumber(80)
+				gw.Spec.Listeners[1].Hostname = &hostname
+				gw.Spec.Listeners[1].Protocol = gatewayv1b1.HTTPSProtocolType
+				gw.Spec.Listeners[1].Port = gatewayv1b1.PortNumber(80)
+			},
+			expectErrsOnFields: []string{"spec.listeners[1].port"},
+		},
 	}
 
 	for name, tc := range testCases {