Add more unit tests.

Signed-off-by: Huang Xin <[email protected]>

Author: gyohuangxin

apis/v1beta1/validation/gateway.go

@@ -136,7 +136,7 @@ func ValidateListenerNames(listeners []gatewayv1b1.Listener, path *field.Path) f
 	return errs
 }
 
-// validateHostnameProtocolPort validates that the combination of port, protocol, and name are
+// validateHostnameProtocolPort validates that the combination of port, protocol, and hostname are
 // unique for each listener.
 func validateHostnameProtocolPort(listeners []gatewayv1b1.Listener, path *field.Path) field.ErrorList {
 	var errs field.ErrorList
@@ -150,7 +150,7 @@ func validateHostnameProtocolPort(listeners []gatewayv1b1.Listener, path *field.
 		port := listener.Port
 		hostnameProtocolPort := fmt.Sprintf("%s:%s:%d", *hostname, protocol, port)
 		if hostnameProtocolPortSets.Has(hostnameProtocolPort) {
-			errs = append(errs, field.Forbidden(path.Index(i), fmt.Sprintln("combination of port, protocol, and name must be unique for each listener")))
+			errs = append(errs, field.Forbidden(path.Index(i), fmt.Sprintln("combination of port, protocol, and hostname must be unique for each listener")))
 		} else {
 			hostnameProtocolPortSets.Insert(hostnameProtocolPort)
 		}

apis/v1beta1/validation/gateway_test.go

@@ -149,7 +149,7 @@ func TestValidateGateway(t *testing.T) {
 			},
 			expectErrsOnFields: []string{"spec.listeners[1].name"},
 		},
-		"combination of port, protocol, and name are not unique for each listener": {
+		"combination of port, protocol, and hostname are not unique for each listener": {
 			mutate: func(gw *gatewayv1b1.Gateway) {
 				hostnameFoo := gatewayv1b1.Hostname("foo.com")
 				gw.Spec.Listeners[0].Name = "foo"
@@ -167,6 +167,86 @@ func TestValidateGateway(t *testing.T) {
 			},
 			expectErrsOnFields: []string{"spec.listeners[1]"},
 		},
+		"combination of port and protocol are not unique for each listenr when hostnames not set": {
+			mutate: func(gw *gatewayv1b1.Gateway) {
+				gw.Spec.Listeners[0].Name = "foo"
+				gw.Spec.Listeners[0].Protocol = gatewayv1b1.HTTPProtocolType
+				gw.Spec.Listeners[0].Port = 80
+				gw.Spec.Listeners = append(gw.Spec.Listeners,
+					gatewayv1b1.Listener{
+						Name:     "bar",
+						Protocol: gatewayv1b1.HTTPProtocolType,
+						Port:     80,
+					},
+				)
+			},
+			expectErrsOnFields: []string{"spec.listeners[1]"},
+		},
+		"port is unique when protocol and hostname are the same": {
+			mutate: func(gw *gatewayv1b1.Gateway) {
+				hostnameFoo := gatewayv1b1.Hostname("foo.com")
+				gw.Spec.Listeners[0].Name = "foo"
+				gw.Spec.Listeners[0].Hostname = &hostnameFoo
+				gw.Spec.Listeners[0].Protocol = gatewayv1b1.HTTPProtocolType
+				gw.Spec.Listeners[0].Port = 80
+				gw.Spec.Listeners = append(gw.Spec.Listeners,
+					gatewayv1b1.Listener{
+						Name:     "bar",
+						Hostname: &hostnameFoo,
+						Protocol: gatewayv1b1.HTTPProtocolType,
+						Port:     8080,
+					},
+				)
+			},
+			expectErrsOnFields: nil,
+		},
+		"hostname is unique when protoco and port are the same": {
+			mutate: func(gw *gatewayv1b1.Gateway) {
+				hostnameFoo := gatewayv1b1.Hostname("foo.com")
+				hostnameBar := gatewayv1b1.Hostname("bar.com")
+				gw.Spec.Listeners[0].Name = "foo"
+				gw.Spec.Listeners[0].Hostname = &hostnameFoo
+				gw.Spec.Listeners[0].Protocol = gatewayv1b1.HTTPProtocolType
+				gw.Spec.Listeners[0].Port = 80
+				gw.Spec.Listeners = append(gw.Spec.Listeners,
+					gatewayv1b1.Listener{
+						Name:     "bar",
+						Hostname: &hostnameBar,
+						Protocol: gatewayv1b1.HTTPProtocolType,
+						Port:     80,
+					},
+				)
+			},
+			expectErrsOnFields: nil,
+		},
+		"protocol is unique when port and hostname are the same": {
+			mutate: func(gw *gatewayv1b1.Gateway) {
+				hostnameFoo := gatewayv1b1.Hostname("foo.com")
+				tlsConfigFoo := tlsConfig
+				tlsModeFoo := gatewayv1b1.TLSModeType("Terminate")
+				tlsConfigFoo.Mode = &tlsModeFoo
+				tlsConfigFoo.CertificateRefs = []gatewayv1b1.SecretObjectReference{
+					{
+						Name: "FooCertificateRefs",
+					},
+				}
+				gw.Spec.Listeners[0].Name = "foo"
+				gw.Spec.Listeners[0].Hostname = &hostnameFoo
+				gw.Spec.Listeners[0].Protocol = gatewayv1b1.HTTPSProtocolType
+				gw.Spec.Listeners[0].Port = 8000
+				gw.Spec.Listeners[0].TLS = &tlsConfigFoo
+				gw.Spec.Listeners = append(gw.Spec.Listeners,
+					gatewayv1b1.Listener{
+						Name:     "bar",
+						Hostname: &hostnameFoo,
+						Protocol: gatewayv1b1.TLSProtocolType,
+						Port:     8000,
+						TLS:      &tlsConfigFoo,
+					},
+				)
+			},
+			expectErrsOnFields: nil,
+		},
 	}
 
 	for name, tc := range testCases {