Skip to content

Commit f4ac1ba

Browse files
committed
Some minor fixes to gep-1762 doc
1 parent 51c32c3 commit f4ac1ba

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

geps/gep-1762.md

+5-6
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ Some common requirements would be:
7777
* Any other arbitrary fields; the list is unbounded. Some examples would be:
7878
* CPU and memory requests
7979
* Service `externalTrafficPolicy`
80-
* Affinity rules.
80+
* Affinity rules
8181

8282
This GEP currently only aims to solve a subset of these concerns. Additional concerns may be addressed in future revisions or other GEPs.
8383

@@ -87,7 +87,7 @@ This is handled by [GEP-1651](https://github.com/kubernetes-sigs/gateway-api/pul
8787

8888
#### Gateway IP
8989

90-
This section just clarifies and existing part of the spec, how to handle `.spec.addresses` for in-cluster implementations.
90+
This section just clarifies an existing part of the spec, how to handle `.spec.addresses` for in-cluster implementations.
9191
Like all other Gateway types, this should impact the address the `Gateway` is reachable at.
9292

9393
For implementations using a `Service`, this means the `clusterIP` or `loadBalancerIP` (depending on the `Service` type).
@@ -112,7 +112,6 @@ spec:
112112

113113
This would generate a `Service` with `clusterIP` or `loadBalancerIP`, depending on the Service type.
114114

115-
116115
#### Labels and Annotations
117116

118117
Labels and annotations for generated resources are specified in `infrastructure`:
@@ -138,7 +137,7 @@ This is typically not a concern; however, if an implementation is aware of speci
138137
exclude these from irrelevant resources.
139138

140139
This is intended to clearly identify resources associated with a specific application, environment, or Gateway.
141-
Additionally, it can be used support integration with the kitchen-sync of Kubernetes extensions which rely on labels and annotations.
140+
Additionally, it can be used support integration with the kitchen-sink of Kubernetes extensions which rely on labels and annotations.
142141

143142
Validation will be added to prevent any usage with `gateway.networking.k8s.io/` prefix, to avoid conflicts with `gateway.networking.k8s.io/gateway-name` or other future additions.
144143

@@ -150,7 +149,7 @@ This can be utilized for the remainder of customizations.
150149

151150
### Resource Attachment
152151

153-
Resources Generated in response to the `Gateway` will have two attributes:
152+
Resources generated in response to the `Gateway` will have two attributes:
154153

155154
* A `gateway.networking.k8s.io/gateway-name: <NAME>` label.
156155
* A name `<NAME>-<GATEWAY CLASS>`. This format is not strictly required for implementations, but strongly recommended for consistency in attachment.
@@ -208,7 +207,7 @@ spec:
208207
selector:
209208
# Match the generated Deployment by label
210209
matchLabels:
211-
gateway.networking.k8s.io/metadata.name: gateway
210+
gateway.networking.k8s.io/gateway-name: gateway
212211
```
213212
214213
Note: there is [discussion](https://github.com/kubernetes-sigs/gateway-api/discussions/1355) around a way to attach a HPA to a Gateway directly.

mkdocs.yml

+1
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ nav:
112112
- geps/gep-1709.md
113113
- geps/gep-1742.md
114114
- geps/gep-1748.md
115+
- geps/gep-1762.md
115116
- geps/gep-1897.md
116117
- geps/gep-1911.md
117118
- geps/gep-2257.md

0 commit comments

Comments
 (0)