Skip to content

Conformance test HTTPRouteInvalidParentRefSectionNameNotMatchingPort included in core instead of extended #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ciarams87 opened this issue Nov 30, 2023 · 5 comments · Fixed by #2623
Assignees
Labels
area/conformance-test Issues or PRs related to Conformance tests. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@ciarams87
Copy link
Contributor

What happened:
This PR introduced a new conformance test to ensure that when both Port and SectionName are specified in a HTTPRoute ParentRef, the name and port of the selected listener must match both specified values.

The issue is that this test was added to the core suite, but ParentRef.Port has extended support, not core.

What you expected to happen:
Tests for features that are extended support should be part of the extended test suite.

How to reproduce it (as minimally and precisely as possible):
Run the conformance test suite against an implementation without ParentRef.Port support. See https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/7041855950/job/19165071974 for an example.

Anything else we need to know?:

@ciarams87 ciarams87 added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2023
@ciarams87
Copy link
Contributor Author

I opened an issue for tracking purposes, but I'm happy to work on the fix for this myself 😁
/assign

@shaneutt shaneutt linked a pull request Nov 30, 2023 that will close this issue
@shaneutt
Copy link
Member

@mlavacca created #2623 before this issue was reported: just heads up you two might be working on the same thing!

@mlavacca
Copy link
Member

mlavacca commented Nov 30, 2023

Yep, this issue will be fixed by #2623. Thanks @shaneutt for being so vigilant 😄

@ciarams87
Copy link
Contributor Author

Oh, I missed this PR - thanks @shaneutt and @mlavacca !

@ciarams87 ciarams87 removed their assignment Nov 30, 2023
@shaneutt
Copy link
Member

shaneutt commented Nov 30, 2023

Yep, sorry for the confusion just a bit of bad timing!

/assign @mlavacca

Thank you so much for taking the time here. If you are looking for more opportunities to contribute to Gateway API and need some support in that, let us know! We're very happy to try and provide that support and we're very active on #sig-network-gateway-api in Kubernetes Slack!

@shaneutt shaneutt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/conformance-test Issues or PRs related to Conformance tests. labels Nov 30, 2023
@shaneutt shaneutt added this to the v1.0.1 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance-test Issues or PRs related to Conformance tests. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants