diff --git a/geps/gep-1762.md b/geps/gep-1762.md index b34572608f..8a30f2a4d3 100644 --- a/geps/gep-1762.md +++ b/geps/gep-1762.md @@ -77,7 +77,7 @@ Some common requirements would be: * Any other arbitrary fields; the list is unbounded. Some examples would be: * CPU and memory requests * Service `externalTrafficPolicy` - * Affinity rules. + * Affinity rules This GEP currently only aims to solve a subset of these concerns. Additional concerns may be addressed in future revisions or other GEPs. @@ -87,7 +87,7 @@ This is handled by [GEP-1651](https://github.com/kubernetes-sigs/gateway-api/pul #### Gateway IP -This section just clarifies and existing part of the spec, how to handle `.spec.addresses` for in-cluster implementations. +This section just clarifies an existing part of the spec, how to handle `.spec.addresses` for in-cluster implementations. Like all other Gateway types, this should impact the address the `Gateway` is reachable at. For implementations using a `Service`, this means the `clusterIP` or `loadBalancerIP` (depending on the `Service` type). @@ -112,7 +112,6 @@ spec: This would generate a `Service` with `clusterIP` or `loadBalancerIP`, depending on the Service type. - #### Labels and Annotations Labels and annotations for generated resources are specified in `infrastructure`: @@ -138,7 +137,7 @@ This is typically not a concern; however, if an implementation is aware of speci exclude these from irrelevant resources. This is intended to clearly identify resources associated with a specific application, environment, or Gateway. -Additionally, it can be used support integration with the kitchen-sync of Kubernetes extensions which rely on labels and annotations. +Additionally, it can be used support integration with the kitchen-sink of Kubernetes extensions which rely on labels and annotations. Validation will be added to prevent any usage with `gateway.networking.k8s.io/` prefix, to avoid conflicts with `gateway.networking.k8s.io/gateway-name` or other future additions. @@ -150,7 +149,7 @@ This can be utilized for the remainder of customizations. ### Resource Attachment -Resources Generated in response to the `Gateway` will have two attributes: +Resources generated in response to the `Gateway` will have two attributes: * A `gateway.networking.k8s.io/gateway-name: ` label. * A name `-`. This format is not strictly required for implementations, but strongly recommended for consistency in attachment. @@ -208,7 +207,7 @@ spec: selector: # Match the generated Deployment by label matchLabels: - gateway.networking.k8s.io/metadata.name: gateway + gateway.networking.k8s.io/gateway-name: gateway ``` Note: there is [discussion](https://github.com/kubernetes-sigs/gateway-api/discussions/1355) around a way to attach a HPA to a Gateway directly. diff --git a/mkdocs.yml b/mkdocs.yml index 31eb7d44a0..6093529af9 100644 --- a/mkdocs.yml +++ b/mkdocs.yml @@ -112,6 +112,7 @@ nav: - geps/gep-1709.md - geps/gep-1742.md - geps/gep-1748.md + - geps/gep-1762.md - geps/gep-1897.md - geps/gep-1911.md - geps/gep-2257.md