Removing LastTransitionTime from the NMC status.

Since we are now checking if a node has rebooted using the node's
`status.nodeInfo.bootID` then we don't need to compare the node's ready
time and the NMC last recorded node ready time anymore.

Signed-off-by: Yoni Bettan <[email protected]>

Author: ybettan

api/v1beta1/nodemodulesconfig_types.go

@@ -67,8 +67,6 @@ type NodeModuleStatus struct {
 	//+optional
 	Config ModuleConfig `json:"config,omitempty"`
 	//+optional
-	LastTransitionTime metav1.Time `json:"lastTransitionTime,omitempty"`
-	//+optional
 	BootId string `json:"bootId,omitempty"`
 }
 

api/v1beta1/zz_generated.deepcopy.go

@@ -369,9 +369,6 @@ spec:
                           type: string
                       type: object
                       x-kubernetes-map-type: atomic
-                    lastTransitionTime:
-                      format: date-time
-                      type: string
                     name:
                       type: string
                     namespace:

config/crd/bases/kmm.sigs.x-k8s.io_nodemodulesconfigs.yaml

@@ -573,12 +573,6 @@ func (h *nmcReconcilerHelperImpl) SyncStatus(ctx context.Context, nmcObj *kmmv1b
 			status.ServiceAccountName = p.Spec.ServiceAccountName
 			status.Tolerations = p.Spec.Tolerations
 
-			podLTT := GetContainerStatus(p.Status.ContainerStatuses, pod.WorkerContainerName).
-				State.
-				Terminated.
-				FinishedAt
-
-			status.LastTransitionTime = podLTT
 			status.BootId = node.Status.NodeInfo.BootID
 
 			nmc.SetModuleStatus(&nmcObj.Status.Modules, *status)

internal/controllers/nmc_reconciler.go

@@ -5,7 +5,6 @@ import (
 	"errors"
 	"fmt"
 	"reflect"
-	"time"
 
 	"github.com/kubernetes-sigs/kernel-module-management/internal/node"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/pod"
@@ -729,11 +728,8 @@ var _ = Describe("nmcReconcilerHelperImpl_ProcessModuleSpec", func() {
 	}
 	node := &v1.Node{}
 
-	now := metav1.Now()
-
 	status := &kmmv1beta1.NodeModuleStatus{
-		Config:             moduleConfig,
-		LastTransitionTime: metav1.Time{Time: now.Add(-1 * time.Minute)},
+		Config: moduleConfig,
 		ModuleItem: kmmv1beta1.ModuleItem{
 			Name:      name,
 			Namespace: namespace,
@@ -1258,8 +1254,7 @@ var _ = Describe("nmcReconcilerHelperImpl_SyncStatus", func() {
 				ServiceAccountName: serviceAccountName,
 				Tolerations:        []v1.Toleration{testToleration},
 			},
-			Config:             cfg,
-			LastTransitionTime: now,
+			Config: cfg,
 		}
 
 		Expect(nmc.Status.Modules[0]).To(BeComparableTo(expectedStatus))

internal/controllers/nmc_reconciler_test.go

@@ -405,7 +405,6 @@ var _ = Describe("SetModuleStatus", func() {
 			InsecurePull:          true,
 			InTreeModulesToRemove: []string{"intree"},
 		},
-		LastTransitionTime: metav1.Now(),
 	}
 
 	It("should do nothing if the slice is nil", func() {