Skip to content

Commit a99f7f6

Browse files
ybettank8s-ci-robot
authored andcommitted
Fixing some kustomizeconfig.yaml files.
Since `[email protected]`, `yaml.UnmarshalStric()` is used instead of `yaml.Unmarshal()` which means that fields in the yamls that doesn't exist in the golang object will fail to unmarshal instead of being ignored like they would without the `strict` behavior. Therefore, those redundant `name` fields where removed. In addition, I have bumped `[email protected]` --> `[email protected]` to make sure we get a closer behavior on machines that comes with `kustomize` pre-installed and those which aren't and install it on-the-fly. I didn't see any diff in the output of `kustomize build config/default` with `[email protected]` and the redundant `name` fields and with `[email protected]` without them. Signed-off-by: Yoni Bettan <[email protected]>
1 parent 3573a4e commit a99f7f6

File tree

4 files changed

+1
-4
lines changed

4 files changed

+1
-4
lines changed
-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
namePrefix:
22
- kind: Deployment
3-
name: controller
43
path: spec/template/spec/volumes/secret/secretName

config/default/kustomizeconfig.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
namePrefix:
22
- kind: Deployment
3-
name: controller
43
path: spec/template/spec/volumes/secret/secretName

config/webhook-cert/kustomizeconfig.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,4 @@ varReference:
1818
namePrefix:
1919
- kind: Certificate
2020
group: cert-manager.io
21-
name: serving-cert
2221
path: spec/secretName

hack/download-kustomize

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ set -euxo pipefail
55
: "$BINDIR"
66

77
readonly TMP=$(mktemp -d)
8-
readonly VERSION=5.3.0
8+
readonly VERSION=5.4.3
99

1010
echo "Downloading kustomize in $TMP"
1111

0 commit comments

Comments
 (0)