Implement unit-test for the first validation case

Author: Erusso7

api/v1beta1/module_webhook.go

@@ -17,7 +17,9 @@ limitations under the License.
 package v1beta1
 
 import (
+	"errors"
 	"k8s.io/apimachinery/pkg/runtime"
+	"regexp"
 	ctrl "sigs.k8s.io/controller-runtime"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
@@ -32,9 +34,6 @@ func (r *Module) SetupWebhookWithManager(mgr ctrl.Manager) error {
 		Complete()
 }
 
-// TODO(user): EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!
-
-// TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.
 //+kubebuilder:webhook:path=/validate-kmm-sigs-x-k8s-io-v1beta1-module,mutating=false,failurePolicy=fail,sideEffects=None,groups=kmm.sigs.x-k8s.io,resources=modules,verbs=create;update,versions=v1beta1,name=vmodule.kb.io,admissionReviewVersions=v1
 
 var _ webhook.Validator = &Module{}
@@ -43,22 +42,39 @@ var _ webhook.Validator = &Module{}
 func (r *Module) ValidateCreate() error {
 	modulelog.Info("validate create", "name", r.Name)
 
-	// TODO(user): fill in your validation logic upon object creation.
+	if err := r.validateKernelMappingRegex(); err != nil {
+		return err
+	}
+
 	return nil
 }
 
 // ValidateUpdate implements webhook.Validator so a webhook will be registered for the type
 func (r *Module) ValidateUpdate(old runtime.Object) error {
 	modulelog.Info("validate update", "name", r.Name)
 
-	// TODO(user): fill in your validation logic upon object update.
+	if err := r.validateKernelMappingRegex(); err != nil {
+		return err
+	}
+
 	return nil
 }
 
 // ValidateDelete implements webhook.Validator so a webhook will be registered for the type
 func (r *Module) ValidateDelete() error {
-	modulelog.Info("validate delete", "name", r.Name)
+	return nil
+}
+
+func (r *Module) validateKernelMappingRegex() error {
+	if r.Spec.ModuleLoader.Container.KernelMappings == nil {
+		return nil
+	}
+
+	for _, km := range r.Spec.ModuleLoader.Container.KernelMappings {
+		if _, rErr := regexp.Compile(km.Regexp); rErr != nil {
+			return errors.New("invalid regex: " + rErr.Error())
+		}
+	}
 
-	// TODO(user): fill in your validation logic upon object deletion.
 	return nil
 }

api/v1beta1/module_webhook_test.go

@@ -0,0 +1,79 @@
+/*
+Copyright 2022.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1beta1
+
+import (
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	"testing"
+)
+
+func TestV1beta1(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "V1beta1 Suite")
+}
+
+var validKMs = []KernelMapping{
+	{Regexp: "valid-regex"},
+}
+
+var invalidKMs = []KernelMapping{
+	{Regexp: "*-invalid-regex"},
+}
+
+var module = &Module{
+	Spec: ModuleSpec{
+		ModuleLoader: ModuleLoaderSpec{
+			Container: ModuleLoaderContainerSpec{
+				KernelMappings: nil,
+			},
+		},
+	},
+}
+
+var _ = BeforeEach(func() {
+	module.Spec.ModuleLoader.Container.KernelMappings = validKMs
+})
+
+var _ = Describe("ValidateCreate", func() {
+	It("should pass when all conditions are met", func() {
+		e := module.ValidateCreate()
+		Expect(e).To(BeNil())
+	})
+
+	It("should fail when an invalid regex is found", func() {
+		m := module
+		m.Spec.ModuleLoader.Container.KernelMappings = invalidKMs
+		e := module.ValidateCreate()
+		Expect(e).To(HaveOccurred())
+		Expect(e.Error()).To(ContainSubstring("invalid regex:"))
+	})
+})
+
+var _ = Describe("ValidateUpdate", func() {
+	It("should pass when all conditions are met", func() {
+		e := module.ValidateUpdate(nil)
+		Expect(e).To(BeNil())
+	})
+})
+
+var _ = Describe("ValidateDelete", func() {
+	It("should do nothing and return always nil", func() {
+		e := module.ValidateDelete()
+		Expect(e).To(BeNil())
+	})
+})