Merge pull request #4736 from kersten/chore/idiomatic-var-slices

🌱 (chore): replace empty slice literals with idiomatic var decls

Author: k8s-ci-robot

docs/book/src/getting-started/testdata/project/internal/controller/memcached_controller_test.go

@@ -94,7 +94,7 @@ var _ = Describe("Memcached Controller", func() {
 
 			By("Checking the latest Status Condition added to the Memcached instance")
 			Expect(k8sClient.Get(ctx, typeNamespacedName, memcached)).To(Succeed())
-			conditions := []metav1.Condition{}
+			var conditions []metav1.Condition
 			Expect(memcached.Status.Conditions).To(ContainElement(
 				HaveField("Type", Equal(typeAvailableMemcached)), &conditions))
 			Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableMemcached)

hack/docs/internal/getting-started/generate_getting_started.go

@@ -85,7 +85,7 @@ func (sp *Sample) updateControllerTest() {
 
 			By("Checking the latest Status Condition added to the Memcached instance")
 			Expect(k8sClient.Get(ctx, typeNamespacedName, memcached)).To(Succeed())
-			conditions := []metav1.Condition{}
+			var conditions []metav1.Condition
 			Expect(memcached.Status.Conditions).To(ContainElement(
 				HaveField("Type", Equal(typeAvailableMemcached)), &conditions))
 			Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableMemcached)

pkg/plugins/external/helpers.go

@@ -254,7 +254,7 @@ func bindSpecificFlags(fs *pflag.FlagSet, flags []external.Flag) {
 }
 
 func filterFlags(flags []external.Flag, externalFlagFilters []externalFlagFilterFunc) []external.Flag {
-	filteredFlags := []external.Flag{}
+	var filteredFlags []external.Flag
 	for _, flag := range flags {
 		ok := true
 		for _, filter := range externalFlagFilters {
@@ -271,7 +271,7 @@ func filterFlags(flags []external.Flag, externalFlagFilters []externalFlagFilter
 }
 
 func filterArgs(args []string, argFilters []argFilterFunc) []string {
-	filteredArgs := []string{}
+	var filteredArgs []string
 	for _, arg := range args {
 		ok := true
 		for _, filter := range argFilters {

pkg/plugins/golang/deploy-image/v1alpha1/scaffolds/internal/templates/controllers/controller-test.go

@@ -191,7 +191,7 @@ var _ = Describe("{{ .Resource.Kind }} controller", func() {
 
 			By("Checking the latest Status Condition added to the {{ .Resource.Kind }} instance")
 			Expect(k8sClient.Get(ctx, typeNamespacedName, {{ lower .Resource.Kind }})).To(Succeed())
-			conditions := []metav1.Condition{}
+			var conditions []metav1.Condition
 			Expect({{ lower .Resource.Kind }}.Status.Conditions).To(ContainElement(
 				HaveField("Type", Equal(typeAvailable{{ .Resource.Kind }})), &conditions))
 			Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailable{{ .Resource.Kind }})

pkg/plugins/optional/grafana/v1alpha/scaffolds/edit.go

@@ -100,7 +100,7 @@ func configReader(reader io.Reader) ([]templates.CustomMetricItem, error) {
 
 func validateCustomMetricItems(rawItems []templates.CustomMetricItem) []templates.CustomMetricItem {
 	// 1. Filter items of missing `Metric` or `Type`
-	filterResult := []templates.CustomMetricItem{}
+	var filterResult []templates.CustomMetricItem
 	for _, item := range rawItems {
 		if hasFields(item) {
 			filterResult = append(filterResult, item)

testdata/project-v4-multigroup/internal/controller/example.com/busybox_controller_test.go

@@ -138,7 +138,7 @@ var _ = Describe("Busybox controller", func() {
 
 			By("Checking the latest Status Condition added to the Busybox instance")
 			Expect(k8sClient.Get(ctx, typeNamespacedName, busybox)).To(Succeed())
-			conditions := []metav1.Condition{}
+			var conditions []metav1.Condition
 			Expect(busybox.Status.Conditions).To(ContainElement(
 				HaveField("Type", Equal(typeAvailableBusybox)), &conditions))
 			Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableBusybox)

testdata/project-v4-multigroup/internal/controller/example.com/memcached_controller_test.go

@@ -139,7 +139,7 @@ var _ = Describe("Memcached controller", func() {
 
 			By("Checking the latest Status Condition added to the Memcached instance")
 			Expect(k8sClient.Get(ctx, typeNamespacedName, memcached)).To(Succeed())
-			conditions := []metav1.Condition{}
+			var conditions []metav1.Condition
 			Expect(memcached.Status.Conditions).To(ContainElement(
 				HaveField("Type", Equal(typeAvailableMemcached)), &conditions))
 			Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableMemcached)

testdata/project-v4-with-plugins/internal/controller/busybox_controller_test.go

@@ -138,7 +138,7 @@ var _ = Describe("Busybox controller", func() {
 
 			By("Checking the latest Status Condition added to the Busybox instance")
 			Expect(k8sClient.Get(ctx, typeNamespacedName, busybox)).To(Succeed())
-			conditions := []metav1.Condition{}
+			var conditions []metav1.Condition
 			Expect(busybox.Status.Conditions).To(ContainElement(
 				HaveField("Type", Equal(typeAvailableBusybox)), &conditions))
 			Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableBusybox)

testdata/project-v4-with-plugins/internal/controller/memcached_controller_test.go

@@ -139,7 +139,7 @@ var _ = Describe("Memcached controller", func() {
 
 			By("Checking the latest Status Condition added to the Memcached instance")
 			Expect(k8sClient.Get(ctx, typeNamespacedName, memcached)).To(Succeed())
-			conditions := []metav1.Condition{}
+			var conditions []metav1.Condition
 			Expect(memcached.Status.Conditions).To(ContainElement(
 				HaveField("Type", Equal(typeAvailableMemcached)), &conditions))
 			Expect(conditions).To(HaveLen(1), "Multiple conditions of type %s", typeAvailableMemcached)