Skip to content

Make install is not working with multiversions #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camilamacedo86 opened this issue Nov 14, 2019 · 2 comments
Closed

Make install is not working with multiversions #1196

camilamacedo86 opened this issue Nov 14, 2019 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@camilamacedo86
Copy link
Member

Bug Report

What did you do?
Follow the quick started and create a v2 for the same Kind. Following the steps to reproduce the issue.

$ mkdir $GOPATH/src/example
$ cd $GOPATH/src/example
$ kubebuilder init --domain my.domain
$ kubebuilder create api --group webapp --version v1 --kind Guestbook
$ kubebuilder create api --group webapp --version v2 --kind Guestbook
$ make install

What did you expect to see?
All worked with success.

What did you see instead? Under which circumstances?

$ make install
/Users/camilamacedo/go/bin/controller-gen "crd:trivialVersions=true" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
test/api/v1:-: CRD for Guestbook.webapp.my.domain has no storage version
Error: not all generators ran successfully
run `controller-gen crd:trivialVersions=true rbac:roleName=manager-role webhook paths=./... output:crd:artifacts:config=config/crd/bases -w` to see all available markers, or `controller-gen crd:trivialVersions=true rbac:roleName=manager-role webhook paths=./... output:crd:artifacts:config=config/crd/bases -h` for usage
make: *** [manifests] Error 1

Environment

  • kubebuilder version: (master branch)
  • go version: 1.13.4
  • Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:36:53Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:09:08Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
  • Kubernetes cluster kind: Minikube

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 14, 2019
@camilamacedo86
Copy link
Member Author

c/c @DirectXMan12 @mengqiy

@DirectXMan12
Copy link
Contributor

If you're using multiple versions, you need to mark one as storage, as noted here: https://book.kubebuilder.io/multiversion-tutorial/api-changes.html#storage-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants