Merge pull request #274 from yongruilin/bool-comparison

k8s-ci-robot · web-flow · commit 7bf59b3d70ee · 2024-12-11T18:44:06.000Z
chore: omit comparison to bool constant
diff --git a/value/scalar.go b/value/scalar.go
@@ -43,7 +43,7 @@ func IntCompare(lhs, rhs int64) int {
 func BoolCompare(lhs, rhs bool) int {
 	if lhs == rhs {
 		return 0
-	} else if lhs == false {
+	} else if !lhs {
 		return -1
 	}
 	return 1

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func IntCompare(lhs, rhs int64) int {`
`43`	`43`	`func BoolCompare(lhs, rhs bool) int {`
`44`	`44`	`if lhs == rhs {`
`45`	`45`	`return 0`
`46`		`- } else if lhs == false {`
	`46`	`+ } else if !lhs {`
`47`	`47`	`return -1`
`48`	`48`	`}`
`49`	`49`	`return 1`