Skip to content

Commit f74ea3c

Browse files
Jefftreek8s-publishing-bot
authored andcommitted
informers: add comment that Start does not block
Signed-off-by: Dr. Stefan Schimanski <[email protected]> Kubernetes-commit: cd69335542fd961b69b4e83b6433d1b40d2f4439
1 parent 80c52b8 commit f74ea3c

File tree

8 files changed

+9
-4
lines changed

8 files changed

+9
-4
lines changed

Diff for: cmd/informer-gen/generators/factory.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ type SharedInformerFactory interface {
300300
// Start initializes all requested informers. They are handled in goroutines
301301
// which run until the stop channel gets closed.
302302
// Warning: Start does not block. When run in a go-routine, it will race with a later WaitForCacheSync.
303-
Start(stopCh <-chan struct{})
303+
Start(stopCh <-chan struct{})
304304
305305
// Shutdown marks a factory as shutting down. At that point no new
306306
// informers can be started anymore and Start will return without

Diff for: examples/HyphenGroup/informers/externalversions/factory.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: examples/MixedCase/informers/externalversions/factory.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: examples/apiserver/informers/externalversions/factory.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: examples/crd/informers/externalversions/factory.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: examples/single/informers/externalversions/factory.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ require (
1313
github.com/spf13/pflag v1.0.5
1414
golang.org/x/text v0.16.0
1515
gopkg.in/yaml.v2 v2.4.0
16-
k8s.io/apimachinery v0.0.0-20240720202316-95b78024e3fe
16+
k8s.io/apimachinery v0.0.0-20240719190441-a8f449e276fe
1717
k8s.io/gengo/v2 v2.0.0-20240228010128-51d4e06bde70
1818
k8s.io/klog/v2 v2.130.1
1919
k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340

Diff for: go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
126126
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
127127
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
128128
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
129-
k8s.io/apimachinery v0.0.0-20240720202316-95b78024e3fe h1:V9MwpYUwbKlfLKVrhpVuKWiat/LBIhm1pGB9/xdHm5Q=
130-
k8s.io/apimachinery v0.0.0-20240720202316-95b78024e3fe/go.mod h1:rsPdaZJfTfLsNJSQzNHQvYoTmxhoOEofxtOsF3rtsMo=
129+
k8s.io/apimachinery v0.0.0-20240719190441-a8f449e276fe h1:lt6b7CTEYMgUTCGIZrATyWMZTQThE+qIQq5YTCbpMVQ=
130+
k8s.io/apimachinery v0.0.0-20240719190441-a8f449e276fe/go.mod h1:rsPdaZJfTfLsNJSQzNHQvYoTmxhoOEofxtOsF3rtsMo=
131131
k8s.io/gengo/v2 v2.0.0-20240228010128-51d4e06bde70 h1:NGrVE502P0s0/1hudf8zjgwki1X/TByhmAoILTarmzo=
132132
k8s.io/gengo/v2 v2.0.0-20240228010128-51d4e06bde70/go.mod h1:VH3AT8AaQOqiGjMF9p0/IM1Dj+82ZwjfxUP1IxaHE+8=
133133
k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=

0 commit comments

Comments
 (0)