Skip to content

Commit 79737aa

Browse files
authored
Merge pull request #7305 from deads2k/ladder
add details for becoming a PRR approver
2 parents 421b880 + 887d371 commit 79737aa

File tree

1 file changed

+22
-3
lines changed

1 file changed

+22
-3
lines changed

sig-architecture/production-readiness.md

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,28 @@ To become a reviewer:
8484
* Read/study previous PRR comments and production readiness responses in existing KEPs.
8585
* Choose some KEPs requiring PRR and perform a review. Put "shadow prod readiness review"
8686
in your review comments so that the assigned PRR approver knows your intent.
87-
* After at least one release cycle, if you have shown good judgement and quality reviews,
88-
you can propose yourself as approver by submitting a PRR to add your GitHub
89-
handle to the `prod-readiness-approvers` alias in [OWNERS_ALIASES].
87+
88+
### Becoming an approver
89+
90+
After serving as reviewer/shadow for at least one release and showing good judgement and quality reviews,
91+
you can propose yourself as an approver by submitting a PR to add your GitHub
92+
handle to the `prod-readiness-approvers` alias in [OWNERS_ALIASES].
93+
94+
When submitting the PR, you should include references to KEPs you reviewed that demonstrated a good variety
95+
of different situations.
96+
Here is a good starting point (remember that one PR can cover multiple categories):
97+
98+
* Transitions from new to alpha
99+
* Transitions from alpha to beta
100+
* Transitions from beta to GA
101+
* Must have successfully reviewed at least three enhancements that require coordination between multiple components.
102+
* Must have successfully reviewed at least three enhancements that require version skew consideration (both HA and component skew):
103+
does behavior fail safely and eventually reconcile.
104+
* Must have successfully reviewed at least three enhancements that are outside your primary domain.
105+
* Examples where the feature requires considering the case of administering thousands of clusters.
106+
This comes up frequently for host-based features in storage, node, or networking.
107+
* Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.
108+
90109

91110
## Finding KEPs needing prod readiness review
92111

0 commit comments

Comments
 (0)