Skip to content
This repository was archived by the owner on Dec 2, 2021. It is now read-only.

Commit ea50a06

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request #1242 from wongma7/metric-names
Automatic merge from submit-queue. Update volume operations metric names as implemented @verult PTAL, thanks! kubernetes/kubernetes#50036 (comment)
2 parents 66dc6df + cba0a72 commit ea50a06

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

storage/volume-metrics.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -50,27 +50,27 @@ Following is a sample of metrics (not exhaustive) that will be added by this pro
5050
```
5151
storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "volume_attach" }
5252
storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "volume_detach" }
53-
storage_operation_duration_seconds { volume_plugin = "glusterfs", operation_name = "provision" }
53+
storage_operation_duration_seconds { volume_plugin = "glusterfs", operation_name = "volume_provision" }
5454
storage_operation_duration_seconds { volume_plugin = "gce-pd", operation_name = "volume_delete" }
5555
storage_operation_duration_seconds { volume_plugin = "vsphere", operation_name = "volume_mount" }
5656
storage_operation_duration_seconds { volume_plugin = "iscsi" , operation_name = "volume_unmount" }
57-
storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "mount_device" }
5857
storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "unmount_device" }
59-
storage_operation_duration_seconds { volume_plugin = "cinder" , operation_name = "verify_volume" }
58+
storage_operation_duration_seconds { volume_plugin = "cinder" , operation_name = "verify_volumes_are_attached" }
59+
storage_operation_duration_seconds { volume_plugin = "<n/a>" , operation_name = "verify_volumes_are_attached_per_node" }
6060
```
6161

6262
Similarly errors will be named:
6363

6464
```
6565
storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "volume_attach" }
6666
storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "volume_detach" }
67-
storage_operation_errors_total { volume_plugin = "glusterfs", operation_name = "provision" }
67+
storage_operation_errors_total { volume_plugin = "glusterfs", operation_name = "volume_provision" }
6868
storage_operation_errors_total { volume_plugin = "gce-pd", operation_name = "volume_delete" }
6969
storage_operation_errors_total { volume_plugin = "vsphere", operation_name = "volume_mount" }
7070
storage_operation_errors_total { volume_plugin = "iscsi" , operation_name = "volume_unmount" }
71-
storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "mount_device" }
7271
storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "unmount_device" }
73-
storage_operation_errors_total { volume_plugin = "cinder" , operation_name = "verify_volume" }
72+
storage_operation_errors_total { volume_plugin = "cinder" , operation_name = "verify_volumes_are_attached" }
73+
storage_operation_errors_total { volume_plugin = "<n/a>" , operation_name = "verify_volumes_are_attached_per_node" }
7474
```
7575

7676
### Implementation Detail

0 commit comments

Comments
 (0)