Skip to content

Commit 9af47a7

Browse files
Remove E2E from Test Plan and clarify shared cache
Signed-off-by: Aldo Culquicondor <[email protected]>
1 parent 180db85 commit 9af47a7

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

keps/sig-scheduling/20200114-multi-scheduling-profiles.md

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,10 @@ the scheduler queue.
243243
framework instance from the registry corresponding to the specified scheduler
244244
name.
245245

246+
Note that all framework instances will make use of the same shared cache
247+
(for nodes and pods), from which a snapshot is taken for each scheduling cycle.
248+
This is the main advantage over running multiple schedulers in a cluster.
249+
246250
### Risks and Mitigations
247251

248252
Operators could introduce profiles that disable scheduling features exposed in
@@ -259,24 +263,24 @@ the scheduler documentation.
259263

260264
The following tests need to be in place:
261265

262-
#### For Alpha
263-
264-
- **Unit Tests**: For Component Config API conversion, validation and defaults, core scheduler and
265-
scheduler instantiation. Current tests that use a default scheduler (or default framework) should
266-
continue passing with no configuration changes.
266+
- **Unit Tests**:
267+
- Component Config API conversion, validation and defaults
268+
- Core scheduler implementation. Current tests that use a default scheduler
269+
(or default framework) should continue passing with no configuration changes.
267270
- **Integration tests**: Current tests with a default scheduler should continue passing with no
268271
configuration changes. We need new tests in `test/integration/scheduler` exercising more than one
269272
profile, in which:
270273
- Each profile would favor specific nodes, so that we can verify assignment.
271274
- Pods get binding events for the selected scheduler name.
272275
- Pods that don't specify a scheduler name continue to be scheduled by the default profile.
273276

277+
*Note on E2E tests*
274278

275-
#### For Beta
276-
277-
- **E2E tests**: A representative case from Integration tests will be replicated as E2E,
278-
to live in `test/e2e/scheduling`. To exercise the custom configuration, we need to set up a new
279-
job in `k8s.io/test-infra/config/jobs/kubernetes/sig-scheduling`.
279+
Due to the proposed architecture, where a single kube-scheduler binary runs all the profiles, E2E
280+
tests wouldn't increase the coverage of this feature over unit and integration tests.
281+
Additionally, profiles can only be provided statically during cluster creation with our current
282+
test infra. This implies that an independent job would be needed for each scheduler configuration.
283+
But, as stated in our goals, this KEP doesn't introduce new default profiles.
280284

281285
### Graduation Criteria
282286

0 commit comments

Comments
 (0)