Skip to content

Commit cf75c49

Browse files
committed
change godoc based on feedback from luxas
1 parent 82a69b2 commit cf75c49

File tree

10 files changed

+10
-10
lines changed

10 files changed

+10
-10
lines changed

Diff for: pkg/cloudprovider/cloud.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ type Instances interface {
141141
// On most clouds (e.g. GCE) this is the hostname, so we provide the hostname
142142
CurrentNodeName(hostname string) (types.NodeName, error)
143143
// InstanceExistsByProviderID returns true if the instance for the given provider id still is running.
144-
// If false is returned with no error, the instance will be immediately deleted.
144+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
145145
InstanceExistsByProviderID(providerID string) (bool, error)
146146
}
147147

Diff for: pkg/cloudprovider/providers/aws/aws.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1102,7 +1102,7 @@ func (c *Cloud) ExternalID(nodeName types.NodeName) (string, error) {
11021102
}
11031103

11041104
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
1105-
// If false is returned with no error, the instance will be immediately deleted.
1105+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
11061106
func (c *Cloud) InstanceExistsByProviderID(providerID string) (bool, error) {
11071107
return false, errors.New("unimplemented")
11081108
}

Diff for: pkg/cloudprovider/providers/azure/azure_instances.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ func (az *Cloud) ExternalID(name types.NodeName) (string, error) {
8888
}
8989

9090
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
91-
// If false is returned with no error, the instance will be immediately deleted.
91+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
9292
func (az *Cloud) InstanceExistsByProviderID(providerID string) (bool, error) {
9393
return false, errors.New("unimplemented")
9494
}

Diff for: pkg/cloudprovider/providers/fake/fake.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ func (f *FakeCloud) InstanceTypeByProviderID(providerID string) (string, error)
239239
}
240240

241241
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
242-
// If false is returned with no error, the instance will be immediately deleted.
242+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
243243
func (f *FakeCloud) InstanceExistsByProviderID(providerID string) (bool, error) {
244244
f.addCall("instance-exists-by-provider-id")
245245
return f.ExistsByProviderID, f.ErrByProviderID

Diff for: pkg/cloudprovider/providers/gce/gce_instances.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func (gce *GCECloud) ExternalID(nodeName types.NodeName) (string, error) {
153153
}
154154

155155
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
156-
// If false is returned with no error, the instance will be immediately deleted.
156+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
157157
func (gce *GCECloud) InstanceExistsByProviderID(providerID string) (bool, error) {
158158
return false, errors.New("unimplemented")
159159
}

Diff for: pkg/cloudprovider/providers/openstack/openstack_instances.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ func (i *Instances) ExternalID(name types.NodeName) (string, error) {
111111
}
112112

113113
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
114-
// If false is returned with no error, the instance will be immediately deleted.
114+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
115115
func (i *Instances) InstanceExistsByProviderID(providerID string) (bool, error) {
116116
return false, errors.New("unimplemented")
117117
}

Diff for: pkg/cloudprovider/providers/ovirt/ovirt.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ func (v *OVirtCloud) ExternalID(nodeName types.NodeName) (string, error) {
212212
}
213213

214214
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
215-
// If false is returned with no error, the instance will be immediately deleted.
215+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
216216
func (v *OVirtCloud) InstanceExistsByProviderID(providerID string) (bool, error) {
217217
return false, errors.New("unimplemented")
218218
}

Diff for: pkg/cloudprovider/providers/photon/photon.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ func (pc *PCCloud) ExternalID(nodeName k8stypes.NodeName) (string, error) {
471471
}
472472

473473
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
474-
// If false is returned with no error, the instance will be immediately deleted.
474+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
475475
func (pc *PCCloud) InstanceExistsByProviderID(providerID string) (bool, error) {
476476
return false, errors.New("unimplemented")
477477
}

Diff for: pkg/cloudprovider/providers/rackspace/rackspace.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ func (i *Instances) ExternalID(nodeName types.NodeName) (string, error) {
437437
}
438438

439439
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
440-
// If false is returned with no error, the instance will be immediately deleted.
440+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
441441
func (i *Instances) InstanceExistsByProviderID(providerID string) (bool, error) {
442442
return false, errors.New("unimplemented")
443443
}

Diff for: pkg/cloudprovider/providers/vsphere/vsphere.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ func (vs *VSphere) ExternalID(nodeName k8stypes.NodeName) (string, error) {
377377
}
378378

379379
// InstanceExistsByProviderID returns true if the instance with the given provider id still exists and is running.
380-
// If false is returned with no error, the instance will be immediately deleted.
380+
// If false is returned with no error, the instance will be immediately deleted by the cloud controller manager.
381381
func (vs *VSphere) InstanceExistsByProviderID(providerID string) (bool, error) {
382382
return false, errors.New("unimplemented")
383383
}

0 commit comments

Comments
 (0)