Skip to content

Remove usage of assertion libraries in pkg/scheduler tests #130407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
macsko opened this issue Feb 25, 2025 · 12 comments · May be fixed by #130710 or #131145
Open

Remove usage of assertion libraries in pkg/scheduler tests #130407

macsko opened this issue Feb 25, 2025 · 12 comments · May be fixed by #130710 or #131145
Assignees
@pjsharath28 @mohitsethia
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@macsko
Copy link
Member

macsko commented Feb 25, 2025

According to SIG Scheduling guidelines, using assertion libraries should be avoided. There are a few occurrences of those in pkg/scheduler tests that should be changed to cmp.Equal and cmp.Diff calls with t.Error or t.Fatal.

/sig scheduling
/kind cleanup
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@googs1025
Copy link
Member

/help

@k8s-ci-robot
Copy link
Contributor

@googs1025:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 25, 2025
@pjsharath28
Copy link
Contributor

/assign

@zhengkezhou1
Copy link

hi @pjsharath28 Are you still working?

@pjsharath28 pjsharath28 linked a pull request Mar 11, 2025 that will close this issue
Open
@pjsharath28
Copy link
Contributor

Hey @zhengkezhou1, sorry for the delay. but yeah I have completed it and raised the PR.

@mohitsethia
Copy link

Hi, is this still being worked on or can I take it?

@haosdent
Copy link
Member

haosdent commented Apr 1, 2025

@mohitsethia I think @pjsharath28 is working on it. The PR link is #130710

@pjsharath28
Copy link
Contributor

Hey @mohitsethia, I don't have bandwidth to continue working on this issue. You can co-author with me on this PR if you're interested.

@mohitsethia
Copy link

Thanks, then I will work on it.

@mohitsethia mohitsethia linked a pull request Apr 1, 2025 that will close this issue
Open
@mohitsethia
Copy link

Hi team, please review this PR.

@mohitsethia
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjsharath28 pjsharath28

@mohitsethia mohitsethia

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
No milestone
7 participants
@haosdent @k8s-ci-robot @zhengkezhou1 @pjsharath28 @mohitsethia @googs1025 @macsko