Skip to content

Stricter server-side validation of JSON entities #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simon3z opened this issue Mar 24, 2015 · 15 comments
Closed

Stricter server-side validation of JSON entities #5889

simon3z opened this issue Mar 24, 2015 · 15 comments
Labels
area/api Indicates an issue on api area. area/apiserver kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@simon3z
Copy link
Contributor

simon3z commented Mar 24, 2015

In issue #5850 we mentioned that we may consider a stricter validation of the JSON entities (explicitly failing on unknown fields instead of ignoring them).

@simon3z
Copy link
Contributor Author

simon3z commented Mar 25, 2015

Sorry @brendandburns I just noticed that you closed #5850, do you think that this issue should be closed as well? In #5850 (comment) @bgrant0607 mentioned:

We should probably also do better server-side validation, but need to think through version-skew cases.

so I thought that it was worth to keep track of the possibility for a better server-side validation.

@bgrant0607 bgrant0607 added area/api Indicates an issue on api area. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 25, 2015
@bgrant0607
Copy link
Member

I think it's a reasonable request, though not something we plan to implement soon.

@bgrant0607
Copy link
Member

See also discussion in #4855.

@bgrant0607 bgrant0607 added priority/backlog Higher priority than priority/awaiting-more-evidence. area/apiserver and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Jun 30, 2015
@bgrant0607 bgrant0607 added this to the v1.2-candidate milestone Sep 12, 2015
@bgrant0607 bgrant0607 removed this from the v1.2-candidate milestone Jan 29, 2016
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 21, 2018
@bgrant0607
Copy link
Member

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 22, 2018
@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 1, 2018
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2019
@liggitt liggitt added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 12, 2019
@rikatz
Copy link
Contributor

rikatz commented Feb 3, 2021

@bgrant0607 @liggitt I guess this one can be closed, right? AFAIK we already have strict validation on server side for unknown fields

@liggitt
Copy link
Member

liggitt commented Feb 3, 2021

AFAIK we already have strict validation on server side for unknown fields

no, unknown fields get dropped by the server

@eddiezane
Copy link
Member

/remove-sig cli

@kevindelgado
Copy link
Contributor

Fixed by #105916

@kevindelgado
Copy link
Contributor

Can we close this @liggitt? (I don't have permissions to)

@liggitt
Copy link
Member

liggitt commented Feb 9, 2022

@liggitt liggitt closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/apiserver kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

8 participants