-
Notifications
You must be signed in to change notification settings - Fork 40.5k
Stricter server-side validation of JSON entities #5889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sorry @brendandburns I just noticed that you closed #5850, do you think that this issue should be closed as well? In #5850 (comment) @bgrant0607 mentioned:
so I thought that it was worth to keep track of the possibility for a better server-side validation. |
I think it's a reasonable request, though not something we plan to implement soon. |
See also discussion in #4855. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
/remove-lifecycle rotten |
@bgrant0607 @liggitt I guess this one can be closed, right? AFAIK we already have strict validation on server side for unknown fields |
no, unknown fields get dropped by the server |
/remove-sig cli |
Fixed by #105916 |
Can we close this @liggitt? (I don't have permissions to) |
tracked in feature https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/2885-server-side-unknown-field-validation alpha in 1.23, targeting beta in 1.24 |
In issue #5850 we mentioned that we may consider a stricter validation of the JSON entities (explicitly failing on unknown fields instead of ignoring them).
The text was updated successfully, but these errors were encountered: