Skip to content

Commit 1317594

Browse files
committed
cni testing: Add post-mortem logs, skip DNS tests for weave
1 parent 03ec6f9 commit 1317594

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/integration/net_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ func TestNetworkPlugins(t *testing.T) {
6666
profile := UniqueProfileName(tc.name)
6767

6868
ctx, cancel := context.WithTimeout(context.Background(), Minutes(40))
69-
defer Cleanup(t, profile, cancel)
69+
defer CleanupWithLogs(t, profile, cancel)
7070

7171
startArgs := append([]string{"start", "-p", profile, "--memory=1800", "--alsologtostderr", "--wait=true", "--wait-timeout=25m"}, tc.args...)
7272
startArgs = append(startArgs, StartArgs()...)
@@ -129,6 +129,10 @@ func TestNetworkPlugins(t *testing.T) {
129129
})
130130
}
131131

132+
if strings.Contains(tc.name, "weave") {
133+
t.Skipf("skipping remaining tests for weave, as results can be unpredictable")
134+
}
135+
132136
if !t.Failed() {
133137
t.Run("DNS", func(t *testing.T) {
134138
var rr *RunResult
@@ -166,10 +170,6 @@ func TestNetworkPlugins(t *testing.T) {
166170

167171
if !t.Failed() {
168172
t.Run("HairPin", func(t *testing.T) {
169-
if strings.Contains(tc.name, "weave") {
170-
t.Skipf("skipping: weavenet hairpin results vary substantially across environments")
171-
}
172-
173173
tryHairPin := func() error {
174174
_, err := Run(t, exec.CommandContext(ctx, "kubectl", "--context", profile, "exec", "deployment/netcat", "--", "/bin/sh", "-c", "nc -w 5 -i 5 -z netcat 8080"))
175175
return err

0 commit comments

Comments
 (0)