@@ -66,7 +66,7 @@ func TestNetworkPlugins(t *testing.T) {
66
66
profile := UniqueProfileName (tc .name )
67
67
68
68
ctx , cancel := context .WithTimeout (context .Background (), Minutes (40 ))
69
- defer Cleanup (t , profile , cancel )
69
+ defer CleanupWithLogs (t , profile , cancel )
70
70
71
71
startArgs := append ([]string {"start" , "-p" , profile , "--memory=1800" , "--alsologtostderr" , "--wait=true" , "--wait-timeout=25m" }, tc .args ... )
72
72
startArgs = append (startArgs , StartArgs ()... )
@@ -129,6 +129,10 @@ func TestNetworkPlugins(t *testing.T) {
129
129
})
130
130
}
131
131
132
+ if strings .Contains (tc .name , "weave" ) {
133
+ t .Skipf ("skipping remaining tests for weave, as results can be unpredictable" )
134
+ }
135
+
132
136
if ! t .Failed () {
133
137
t .Run ("DNS" , func (t * testing.T ) {
134
138
var rr * RunResult
@@ -166,10 +170,6 @@ func TestNetworkPlugins(t *testing.T) {
166
170
167
171
if ! t .Failed () {
168
172
t .Run ("HairPin" , func (t * testing.T ) {
169
- if strings .Contains (tc .name , "weave" ) {
170
- t .Skipf ("skipping: weavenet hairpin results vary substantially across environments" )
171
- }
172
-
173
173
tryHairPin := func () error {
174
174
_ , err := Run (t , exec .CommandContext (ctx , "kubectl" , "--context" , profile , "exec" , "deployment/netcat" , "--" , "/bin/sh" , "-c" , "nc -w 5 -i 5 -z netcat 8080" ))
175
175
return err
0 commit comments