Merge pull request #13777 from prezha/fix-k8s-versions

use upstream github project's release versions' tags insted of just release tags for stable, latest and edge

Author: spowelljr

Diff for: go.mod

@@ -24,7 +24,6 @@ require (
 	github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
 	github.com/google/go-cmp v0.5.8
 	github.com/google/go-containerregistry v0.6.0
-	github.com/google/go-github/v36 v36.0.0
 	github.com/google/slowjam v1.0.0
 	github.com/google/uuid v1.3.0
 	github.com/hashicorp/go-getter v1.6.1

Diff for: go.sum

@@ -576,8 +576,6 @@ github.com/google/go-cmp v0.5.8/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeN
 github.com/google/go-containerregistry v0.6.0 h1:niQ+8XD//kKgArIFwDVBXsWVWbde16LPdHMyNwSC8h4=
 github.com/google/go-containerregistry v0.6.0/go.mod h1:euCCtNbZ6tKqi1E72vwDj2xZcN5ttKpZLfa/wSo5iLw=
 github.com/google/go-github v17.0.0+incompatible/go.mod h1:zLgOLi98H3fifZn+44m+umXrS52loVEgC2AApnigrVQ=
-github.com/google/go-github/v36 v36.0.0 h1:ndCzM616/oijwufI7nBRa+5eZHLldT+4yIB68ib5ogs=
-github.com/google/go-github/v36 v36.0.0/go.mod h1:LFlKC047IOqiglRGNqNb9s/iAPTnnjtlshm+bxp+kwk=
 github.com/google/go-github/v43 v43.0.0 h1:y+GL7LIsAIF2NZlJ46ZoC/D1W1ivZasT0lnWHMYPZ+U=
 github.com/google/go-github/v43 v43.0.0/go.mod h1:ZkTvvmCXBvsfPpTHXnH/d2hP9Y0cTbvN9kr5xqyXOIc=
 github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=

Diff for: hack/preload-images/kubernetes.go

@@ -20,7 +20,7 @@ import (
 	"context"
 	"strings"
 
-	"github.com/google/go-github/v36/github"
+	"github.com/google/go-github/v43/github"
 
 	"k8s.io/klog/v2"
 )

Diff for: hack/update/github.go

@@ -26,7 +26,7 @@ import (
 	"golang.org/x/mod/semver"
 	"golang.org/x/oauth2"
 
-	"github.com/google/go-github/v36/github"
+	"github.com/google/go-github/v43/github"
 	"k8s.io/klog/v2"
 )
 
@@ -36,7 +36,7 @@ const (
 	ghListPerPage = 100
 
 	// ghSearchLimit limits the number of searched items to be <= N * ghListPerPage.
-	ghSearchLimit = 100
+	ghSearchLimit = 300
 )
 
 var (
@@ -55,13 +55,13 @@ func ghCreatePR(ctx context.Context, owner, repo, base, branch, title string, is
 	ghc := ghClient(ctx, token)
 
 	// get base branch
-	baseBranch, _, err := ghc.Repositories.GetBranch(ctx, owner, repo, base)
+	baseBranch, _, err := ghc.Repositories.GetBranch(ctx, owner, repo, base, true)
 	if err != nil {
 		return nil, fmt.Errorf("unable to get base branch: %w", err)
 	}
 
 	// get base commit
-	baseCommit, _, err := ghc.Repositories.GetCommit(ctx, owner, repo, *baseBranch.Commit.SHA)
+	baseCommit, _, err := ghc.Repositories.GetCommit(ctx, owner, repo, *baseBranch.Commit.SHA, &github.ListOptions{PerPage: ghListPerPage})
 	if err != nil {
 		return nil, fmt.Errorf("unable to get base commit: %w", err)
 	}
@@ -216,12 +216,12 @@ func GHReleases(ctx context.Context, owner, repo string) (stable, latest, edge s
 	// walk through the paginated list of up to ghSearchLimit newest releases
 	opts := &github.ListOptions{PerPage: ghListPerPage}
 	for (opts.Page+1)*ghListPerPage <= ghSearchLimit {
-		rls, resp, err := ghc.Repositories.ListTags(ctx, owner, repo, opts)
+		rls, resp, err := ghc.Repositories.ListReleases(ctx, owner, repo, opts)
 		if err != nil {
 			return "", "", "", err
 		}
 		for _, rl := range rls {
-			ver := *rl.Name
+			ver := rl.GetTagName()
 			if !semver.IsValid(ver) {
 				continue
 			}

Diff for: pkg/minikube/constants/constants.go

@@ -32,7 +32,6 @@ var (
 
 const (
 	// DefaultKubernetesVersion is the default Kubernetes version
-	// dont update till #10545 is solved
 	DefaultKubernetesVersion = "v1.23.6"
 	// NewestKubernetesVersion is the newest Kubernetes version to test against
 	// NOTE: You may need to update coreDNS & etcd versions in pkg/minikube/bootstrapper/images/images.go

Diff for: pkg/perf/monitor/github.go

@@ -22,7 +22,7 @@ import (
 	"os"
 	"time"
 
-	"github.com/google/go-github/v36/github"
+	"github.com/google/go-github/v43/github"
 	"github.com/pkg/errors"
 	"golang.org/x/oauth2"
 )