Skip to content

Commit 1e0e050

Browse files
committed
Added defaultDiskSize setup to hyperkit driver
1 parent e6b60fb commit 1e0e050

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

pkg/drivers/hyperkit/driver.go

+2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import (
3636
nfsexports "github.com/johanneswuerbach/nfsexports"
3737
hyperkit "github.com/moby/hyperkit/go"
3838
"github.com/pkg/errors"
39+
"k8s.io/minikube/pkg/minikube/constants"
3940
pkgdrivers "k8s.io/minikube/pkg/drivers"
4041
commonutil "k8s.io/minikube/pkg/util"
4142
)
@@ -70,6 +71,7 @@ func NewDriver(hostName, storePath string) *Driver {
7071
SSHUser: "docker",
7172
},
7273
CommonDriver: &pkgdrivers.CommonDriver{},
74+
DiskSize: commonutil.CalculateDiskSizeInMB(constants.DefaultDiskSize),
7375
}
7476
}
7577

pkg/drivers/hyperkit/driver_test.go

+13
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ package hyperkit
2020

2121
import (
2222
"testing"
23+
24+
"k8s.io/minikube/pkg/minikube/constants"
25+
26+
commonutil "k8s.io/minikube/pkg/util"
2327
)
2428

2529
func Test_portExtraction(t *testing.T) {
@@ -62,6 +66,15 @@ func Test_portExtraction(t *testing.T) {
6266
}
6367
}
6468

69+
func Test_defaultDiskSize(t *testing.T) {
70+
expectedDefaultDiscSize := commonutil.CalculateDiskSizeInMB(constants.DefaultDiskSize)
71+
driver := NewDriver("", "")
72+
got := driver.DiskSize
73+
if got != expectedDefaultDiscSize {
74+
t.Errorf("Unexpected default disk size got: %v, want: %v", got, expectedDefaultDiscSize)
75+
}
76+
}
77+
6578
func testEq(a, b []int) bool {
6679

6780
if a == nil && b == nil {

0 commit comments

Comments
 (0)