Skip to content

Commit 46061f1

Browse files
committed
ensure that both 'crio' and 'cri-o' are accepted as valid options
1 parent 5f40f86 commit 46061f1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cmd/minikube/cmd/start_flags.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ func initMinikubeFlags() {
127127
startCmd.Flags().String(kicBaseImage, kic.BaseImage, "The base image to use for docker/podman drivers. Intended for local development.")
128128
startCmd.Flags().Bool(keepContext, false, "This will keep the existing kubectl context and will create a minikube context.")
129129
startCmd.Flags().Bool(embedCerts, false, "if true, will embed the certs in kubeconfig.")
130-
startCmd.Flags().String(containerRuntime, "docker", fmt.Sprintf("The container runtime to be used (%s).", strings.Join(cruntime.ValidRuntimes(), ", ")))
130+
startCmd.Flags().String(containerRuntime, "docker", "The container runtime to be used (docker, crio, containerd).")
131131
startCmd.Flags().Bool(createMount, false, "This will start the mount daemon and automatically mount files into minikube.")
132132
startCmd.Flags().String(mountString, constants.DefaultMountDir+":/minikube-host", "The argument to pass the minikube mount command on start.")
133133
startCmd.Flags().StringArrayVar(&config.AddonList, "addons", nil, "Enable addons. see `minikube addons list` for a list of valid addon names.")

pkg/minikube/cruntime/cruntime.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ func (cs ContainerState) String() string {
4949

5050
// ValidRuntimes lists the supported container runtimes
5151
func ValidRuntimes() []string {
52-
return []string{"docker", "crio", "containerd"}
52+
return []string{"docker", "cri-o", "crio", "containerd"}
5353
}
5454

5555
// CommandRunner is the subset of command.Runner this package consumes

0 commit comments

Comments
 (0)