Skip to content

Commit 59274b2

Browse files
dlorencdlorenc
dlorenc
authored andcommitted
Code review feedback.
1 parent e3f3727 commit 59274b2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

cmd/minikube/cmd/start.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -371,8 +371,8 @@ func init() {
371371
startCmd.Flags().String(hypervVirtualSwitch, "", "The hyperv virtual switch name. Defaults to first found. (only supported with HyperV driver)")
372372
startCmd.Flags().String(kvmNetwork, "default", "The KVM network name. (only supported with KVM driver)")
373373
startCmd.Flags().String(xhyveDiskDriver, "ahci-hd", "The disk driver to use [ahci-hd|virtio-blk] (only supported with xhyve driver)")
374-
startCmd.Flags().StringSlice(NFSShare, []string{}, "Local folders to share with Guest via NFS mounts")
375-
startCmd.Flags().String(NFSSharesRoot, "/nfsshares", "Where to root the NFS Shares (defaults to /nfsshares)")
374+
startCmd.Flags().StringSlice(NFSShare, []string{}, "Local folders to share with Guest via NFS mounts (Only supported on with hyperkit now)")
375+
startCmd.Flags().String(NFSSharesRoot, "/nfsshares", "Where to root the NFS Shares (defaults to /nfsshares, only supported with hyperkit now)")
376376
startCmd.Flags().StringArrayVar(&dockerEnv, "docker-env", nil, "Environment variables to pass to the Docker daemon. (format: key=value)")
377377
startCmd.Flags().StringArrayVar(&dockerOpt, "docker-opt", nil, "Specify arbitrary flags to pass to the Docker daemon. (format: key=value)")
378378
startCmd.Flags().String(apiServerName, constants.APIServerName, "The apiserver name which is used in the generated certificate for localkube/kubernetes. This can be used if you want to make the apiserver available from outside the machine")

pkg/drivers/hyperkit/driver.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ func (d *Driver) setupNFSShare() error {
297297
}
298298

299299
func (d *Driver) nfsExportIdentifier(path string) string {
300-
return fmt.Sprintf("docker-machine-driver-hyperkit %s-%s", d.MachineName, path)
300+
return fmt.Sprintf("minikube-hyperkit %s-%s", d.MachineName, path)
301301
}
302302

303303
func (d *Driver) sendSignal(s os.Signal) error {

0 commit comments

Comments
 (0)