Skip to content

Commit 60f1230

Browse files
committed
fix condition check for extraOpts validation
1 parent 6b48953 commit 60f1230

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cmd/minikube/cmd/start.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,7 @@ func validateFlags(cmd *cobra.Command, drvName string) {
849849
}
850850

851851
// validate kubeadm extra args
852-
if invalidOpts := bsutil.FindInvalidExtraConfigFlags(config.ExtraOptions); invalidOpts != nil {
852+
if invalidOpts := bsutil.FindInvalidExtraConfigFlags(config.ExtraOptions); len(invalidOpts) > 0 {
853853
out.ErrT(
854854
out.Warning,
855855
"These --extra-config parameters are invalid: {{.invalid_extra_opts}}",

pkg/minikube/bootstrapper/bsutil/extraconfig.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ func defaultOptionsForComponentAndVersion(component string, version semver.Versi
147147

148148
// newComponentOptions creates a new componentOptions
149149
func newComponentOptions(opts config.ExtraOptionSlice, version semver.Version, featureGates string, cp config.Node) ([]componentOptions, error) {
150-
if invalidOpts := FindInvalidExtraConfigFlags(opts); invalidOpts != nil {
150+
if invalidOpts := FindInvalidExtraConfigFlags(opts); len(invalidOpts) > 0 {
151151
return nil, fmt.Errorf("unknown components %v. valid components are: %v", invalidOpts, KubeadmExtraConfigOpts)
152152
}
153153

0 commit comments

Comments
 (0)