Skip to content

Commit 6ce802b

Browse files
committed
Clean up and fix logic after all refactoring
1 parent 8a027b5 commit 6ce802b

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

pkg/minikube/image/image.go

+10-4
Original file line numberDiff line numberDiff line change
@@ -216,19 +216,25 @@ func retrieveImage(ref name.Reference) (v1.Image, error) {
216216
var err error
217217
var img v1.Image
218218

219+
if !useDaemon && !useRemote {
220+
return nil, fmt.Errorf("neither daemon nor remote")
221+
}
222+
219223
klog.Infof("retrieving image: %+v", ref)
220224
if useDaemon {
221225
img, err = retrieveDaemon(ref)
226+
if err == nil {
227+
return img, nil
228+
}
222229
}
223230
if useRemote {
224231
img, err = retrieveRemote(ref, defaultPlatform)
225-
if err != nil {
226-
return nil, err
232+
if err == nil {
233+
return fixPlatform(ref, img, defaultPlatform)
227234
}
228-
return fixPlatform(ref, img, defaultPlatform)
229235
}
230236

231-
return img, err
237+
return nil, err
232238
}
233239

234240
func retrieveDaemon(ref name.Reference) (v1.Image, error) {

0 commit comments

Comments
 (0)