Skip to content

Commit 88c51d7

Browse files
authored
Merge pull request #6509 from tstromberg/faster-health
Remove pod list stability double check
2 parents 852d617 + 2ba6c11 commit 88c51d7

File tree

1 file changed

+5
-15
lines changed
  • pkg/minikube/bootstrapper/bsutil/kverify

1 file changed

+5
-15
lines changed

pkg/minikube/bootstrapper/bsutil/kverify/kverify.go

+5-15
Original file line numberDiff line numberDiff line change
@@ -71,31 +71,21 @@ func apiServerPID(cr command.Runner) (int, error) {
7171
func SystemPods(client *kubernetes.Clientset, start time.Time, timeout time.Duration) error {
7272
glog.Info("waiting for kube-system pods to appear ...")
7373
pStart := time.Now()
74-
podStart := time.Time{}
7574
podList := func() (bool, error) {
7675
if time.Since(start) > timeout {
7776
return false, fmt.Errorf("cluster wait timed out during pod check")
7877
}
7978
// Wait for any system pod, as waiting for apiserver may block until etcd
8079
pods, err := client.CoreV1().Pods("kube-system").List(meta.ListOptions{})
81-
if len(pods.Items) < 2 {
82-
podStart = time.Time{}
83-
return false, nil
84-
}
8580
if err != nil {
86-
podStart = time.Time{}
81+
glog.Warningf("pod list returned error: %v", err)
8782
return false, nil
8883
}
89-
if podStart.IsZero() {
90-
podStart = time.Now()
91-
}
92-
93-
glog.Infof("%d kube-system pods found since %s", len(pods.Items), podStart)
94-
if time.Since(podStart) > 2*kconst.APICallRetryInterval {
95-
glog.Infof("stability requirement met, returning")
96-
return true, nil
84+
glog.Infof("%d kube-system pods found", len(pods.Items))
85+
if len(pods.Items) < 2 {
86+
return false, nil
9787
}
98-
return false, nil
88+
return true, nil
9989
}
10090
if err := wait.PollImmediate(kconst.APICallRetryInterval, kconst.DefaultControlPlaneTimeout, podList); err != nil {
10191
return fmt.Errorf("apiserver never returned a pod list")

0 commit comments

Comments
 (0)