Skip to content

Commit 919fee1

Browse files
author
dlorenc
committed
Move GetNetAddr.
The build constraints in vmnet.go cause issues.
1 parent af5a475 commit 919fee1

File tree

3 files changed

+24
-29
lines changed

3 files changed

+24
-29
lines changed

pkg/drivers/hyperkit/network.go

+21
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,17 @@ import (
2020
"bufio"
2121
"fmt"
2222
"io"
23+
"net"
2324
"os"
25+
"os/exec"
2426
"regexp"
2527
"strings"
2628
)
2729

2830
const (
2931
DHCPLeasesFile = "/var/db/dhcpd_leases"
32+
CONFIG_PLIST = "/Library/Preferences/SystemConfiguration/com.apple.vmnet"
33+
NET_ADDR_KEY = "Shared_Net_Address"
3034
)
3135

3236
type DHCPEntry struct {
@@ -108,3 +112,20 @@ func trimMacAddress(rawUUID string) string {
108112

109113
return mac
110114
}
115+
116+
func GetNetAddr() (net.IP, error) {
117+
_, err := os.Stat(CONFIG_PLIST + ".plist")
118+
if err != nil {
119+
return nil, fmt.Errorf("Does not exist %s", CONFIG_PLIST+".plist")
120+
}
121+
122+
out, err := exec.Command("defaults", "read", CONFIG_PLIST, NET_ADDR_KEY).Output()
123+
if err != nil {
124+
return nil, err
125+
}
126+
ip := net.ParseIP(strings.TrimSpace(string(out)))
127+
if ip == nil {
128+
return nil, fmt.Errorf("Could not get the network address for vmnet")
129+
}
130+
return ip, nil
131+
}

pkg/drivers/hyperkit/vmnet.go

-28
Original file line numberDiff line numberDiff line change
@@ -19,37 +19,9 @@ limitations under the License.
1919
package hyperkit
2020

2121
import (
22-
"fmt"
23-
"net"
24-
"os"
25-
"os/exec"
26-
"strings"
27-
2822
vmnet "github.com/zchee/go-vmnet"
2923
)
3024

31-
const (
32-
CONFIG_PLIST = "/Library/Preferences/SystemConfiguration/com.apple.vmnet"
33-
NET_ADDR_KEY = "Shared_Net_Address"
34-
)
35-
3625
func GetMACAddressFromUUID(UUID string) (string, error) {
3726
return vmnet.GetMACAddressFromUUID(UUID)
3827
}
39-
40-
func GetNetAddr() (net.IP, error) {
41-
_, err := os.Stat(CONFIG_PLIST + ".plist")
42-
if err != nil {
43-
return nil, fmt.Errorf("Does not exist %s", CONFIG_PLIST+".plist")
44-
}
45-
46-
out, err := exec.Command("defaults", "read", CONFIG_PLIST, NET_ADDR_KEY).Output()
47-
if err != nil {
48-
return nil, err
49-
}
50-
ip := net.ParseIP(strings.TrimSpace(string(out)))
51-
if ip == nil {
52-
return nil, fmt.Errorf("Could not get the network address for vmnet")
53-
}
54-
return ip, nil
55-
}

pkg/drivers/hyperkit/vmnet_stub.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ limitations under the License.
1818

1919
package hyperkit
2020

21-
import "errors"
21+
import (
22+
"errors"
23+
)
2224

2325
func GetMACAddressFromUUID(UUID string) (string, error) {
2426
return "", errors.New("Function not supported on CGO_ENABLED=0 binaries")

0 commit comments

Comments
 (0)