Skip to content

Commit a128bbb

Browse files
authored
Merge pull request #9819 from afbjorklund/virtualbox-amd64
Debian installer: only recommend virtualbox when running on amd64
2 parents 3fe2a3c + 71de27f commit a128bbb

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Makefile

+5
Original file line numberDiff line numberDiff line change
@@ -462,6 +462,11 @@ out/minikube_$(DEB_VERSION)-0_%.deb: out/minikube-linux-%
462462
chmod 0755 out/minikube_$(DEB_VERSION)/DEBIAN
463463
sed -E -i 's/--VERSION--/'$(DEB_VERSION)'/g' out/minikube_$(DEB_VERSION)/DEBIAN/control
464464
sed -E -i 's/--ARCH--/'$*'/g' out/minikube_$(DEB_VERSION)/DEBIAN/control
465+
if [ "$*" = "amd64" ]; then \
466+
sed -E -i 's/--RECOMMENDS--/virtualbox/' out/minikube_$(DEB_VERSION)/DEBIAN/control; \
467+
else \
468+
sed -E -i '/Recommends: --RECOMMENDS--/d' out/minikube_$(DEB_VERSION)/DEBIAN/control; \
469+
fi
465470
mkdir -p out/minikube_$(DEB_VERSION)/usr/bin
466471
cp $< out/minikube_$(DEB_VERSION)/usr/bin/minikube
467472
fakeroot dpkg-deb --build out/minikube_$(DEB_VERSION) $@

installers/linux/deb/minikube_deb_template/DEBIAN/control

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Version: --VERSION--
33
Section: base
44
Priority: optional
55
Architecture: --ARCH--
6-
Recommends: virtualbox
6+
Recommends: --RECOMMENDS--
77
Maintainer: Thomas Strömberg <[email protected]>
88
Description: Minikube
99
minikube is a tool that makes it easy to run Kubernetes locally.

0 commit comments

Comments
 (0)