Skip to content

Commit b3f1eb8

Browse files
authored
Merge pull request #4194 from afbjorklund/maketargets
Fix the deploy targets, restore default target
2 parents baa0bd0 + e29ce78 commit b3f1eb8

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

Makefile

+13-12
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,18 @@ else
108108
ARCHTAG_NONE ?= -$(GOARCH)
109109
endif
110110

111-
.PHONY: makedeploys
112-
makedeploys:
113-
sed "s|\-ARCHTAG_NONE|$(ARCHTAG_NONE)|g" deploy/addons/addon-manager.template > deploy/addons/addon-manager.yaml
114-
sed "s|\-ARCHTAG|$(ARCHTAG)|g" deploy/addons/dashboard/dashboard-dp.template > deploy/addons/dashboard/dashboard-dp.yaml
115-
sed "s|\-ARCHTAG|$(ARCHTAG)|g" deploy/addons/heapster/heapster-rc.template > deploy/addons/heapster/heapster-rc.yaml
116-
sed "s|\-ARCHTAG|$(ARCHTAG)|g" deploy/addons/heapster/influx-grafana-rc.template > deploy/addons/heapster/influx-grafana-rc.yaml
117-
sed "s|\-ARCHTAG_NONE|$(ARCHTAG_NONE)|g" deploy/addons/ingress/ingress-dp.template > deploy/addons/ingress/ingress-dp.yaml
118-
sed "s|\-ARCHTAG|$(ARCHTAG)|g" deploy/addons/metrics-server/metrics-server-deployment.template > deploy/addons/metrics-server/metrics-server-deployment.yaml
119-
sed "s|\-ARCHTAG_NONE|$(ARCHTAG_NONE)|g" deploy/addons/storage-provisioner/storage-provisioner.template > deploy/addons/storage-provisioner/storage-provisioner.yaml
120-
111+
DEPLOYS=\
112+
deploy/addons/addon-manager.yaml \
113+
deploy/addons/dashboard/dashboard-dp.yaml \
114+
deploy/addons/heapster/heapster-rc.yaml \
115+
deploy/addons/heapster/influx-grafana-rc.yaml \
116+
deploy/addons/ingress/ingress-dp.yaml \
117+
deploy/addons/metrics-server/metrics-server-deployment.yaml \
118+
deploy/addons/storage-provisioner/storage-provisioner.yaml
119+
120+
%.yaml: %.template
121+
sed "s|\-ARCHTAG_NONE|$(ARCHTAG_NONE)|g;s|\-ARCHTAG|$(ARCHTAG)|g" $< > $@
122+
121123
out/minikube$(IS_EXE): out/minikube-$(GOOS)-$(GOARCH)$(IS_EXE)
122124
cp $< $@
123125

@@ -129,8 +131,7 @@ out/minikube.d: pkg/minikube/assets/assets.go
129131

130132
-include out/minikube.d
131133

132-
PHONY: out/minikube-%
133-
out/minikube-%:makedeploys pkg/minikube/assets/assets.go
134+
out/minikube-%: $(DEPLOYS) pkg/minikube/assets/assets.go
134135
ifeq ($(MINIKUBE_BUILD_IN_DOCKER),y)
135136
$(call DOCKER,$(BUILD_IMAGE),/usr/bin/make $@)
136137
else

0 commit comments

Comments
 (0)