Skip to content

Commit b470860

Browse files
committed
fix condition check for extraOpts validation
1 parent ccffa40 commit b470860

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cmd/minikube/cmd/start.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,7 @@ func validateFlags(cmd *cobra.Command, drvName string) {
873873
}
874874

875875
// validate kubeadm extra args
876-
if invalidOpts := bsutil.FindInvalidExtraConfigFlags(config.ExtraOptions); invalidOpts != nil {
876+
if invalidOpts := bsutil.FindInvalidExtraConfigFlags(config.ExtraOptions); len(invalidOpts) > 0 {
877877
out.ErrT(
878878
out.Warning,
879879
"These --extra-config parameters are invalid: {{.invalid_extra_opts}}",

pkg/minikube/bootstrapper/bsutil/extraconfig.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ func defaultOptionsForComponentAndVersion(component string, version semver.Versi
148148

149149
// newComponentOptions creates a new componentOptions
150150
func newComponentOptions(opts config.ExtraOptionSlice, version semver.Version, featureGates string, cp config.Node) ([]componentOptions, error) {
151-
if invalidOpts := FindInvalidExtraConfigFlags(opts); invalidOpts != nil {
151+
if invalidOpts := FindInvalidExtraConfigFlags(opts); len(invalidOpts) > 0 {
152152
return nil, fmt.Errorf("unknown components %v. valid components are: %v", invalidOpts, KubeadmExtraConfigOpts)
153153
}
154154

0 commit comments

Comments
 (0)