Skip to content

Commit c5612f2

Browse files
committed
Review feedback
1 parent d664536 commit c5612f2

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

cmd/minikube/cmd/config/util.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,15 @@ func EnableOrDisableAddon(name string, val string) error {
108108
}
109109
if enable {
110110
for _, addon := range addon.Assets {
111-
cmd.Copy(addon)
111+
if err := cmd.Copy(addon); err != nil {
112+
return errors.Wrapf(err, "error enabling addon %s: %s", addon.AssetName)
113+
}
112114
}
113115
} else {
114116
for _, addon := range addon.Assets {
115-
cmd.Remove(addon)
117+
if err := cmd.Remove(addon); err != nil {
118+
return errors.Wrapf(err, "error disabling addon %s: %s", addon.AssetName)
119+
}
116120
}
117121
}
118122
return nil

cmd/minikube/cmd/status.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ var statusCmd = &cobra.Command{
6868
}
6969
cmdRunner, err := machine.GetCommandRunner(h)
7070
if err != nil {
71-
glog.Exitln("Error getting command runner interface")
71+
glog.Errorln("Error getting command runner interface")
72+
cmdUtil.MaybeReportErrorAndExit(err)
7273
}
7374
cs, err = cluster.GetLocalkubeStatus(cmdRunner)
7475
if err != nil {

0 commit comments

Comments
 (0)