Skip to content

Commit d6acf7f

Browse files
author
Priya Wadhwa
committed
fix issues
1 parent 4cff790 commit d6acf7f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Diff for: pkg/drivers/kic/kic.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,9 @@ func (d *Driver) Create() error {
157157
glog.Infof("duration metric: took %f seconds to extract preloaded images to volume", time.Since(t).Seconds())
158158
}
159159
}()
160+
if pErr == oci.ErrInsufficientDockerStorage {
161+
return pErr
162+
}
160163

161164
if err := oci.CreateContainerNode(params); err != nil {
162165
return errors.Wrap(err, "create kic node")
@@ -167,7 +170,7 @@ func (d *Driver) Create() error {
167170
}
168171

169172
waitForPreload.Wait()
170-
return pErr
173+
return nil
171174
}
172175

173176
// prepareSSH will generate keys and copy to the container so minikube ssh works

Diff for: test/integration/status_test.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import (
3030
"k8s.io/minikube/cmd/minikube/cmd"
3131
"k8s.io/minikube/pkg/minikube/constants"
3232
"k8s.io/minikube/pkg/minikube/localpath"
33-
"k8s.io/minikube/pkg/minikube/reason"
3433
)
3534

3635
func TestInsufficientStorage(t *testing.T) {
@@ -85,7 +84,7 @@ func verifyClusterState(t *testing.T, contents []byte) {
8584
t.Fatalf("unmarshalling: %v", err)
8685
}
8786
// verify the status looks as we expect
88-
if cs.StatusCode != reason.ExInsufficientStorage {
87+
if cs.StatusCode != cmd.InsufficientStorage {
8988
t.Fatalf("incorrect status code: %v", cs.StatusCode)
9089
}
9190
if cs.StatusName != "InsufficientStorage" {

0 commit comments

Comments
 (0)