Skip to content

Commit e657120

Browse files
committed
Added check to exit app and show error message if number of cpus
is less than the minimum required.
1 parent 99f5771 commit e657120

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

Diff for: cmd/minikube/cmd/start.go

+5
Original file line numberDiff line numberDiff line change
@@ -536,6 +536,11 @@ func validateConfig() {
536536
out.V{"memory": memorySizeMB, "default_memorysize": pkgutil.CalculateSizeInMB(constants.DefaultMemorySize)})
537537
}
538538

539+
cpuCount = viper.GetInt(cpus)
540+
if cpuCount < constants.MinimumCPUS {
541+
exit.UsageT("Requested cpu count {{.requested_cpus}} is less than the minimum allowed of {{.minimum_cpus}}", out.V{"requested_cpus": cpuCount, "minimum_cpus": constants.MinimumCPUS})
542+
}
543+
539544
// check that kubeadm extra args contain only whitelisted parameters
540545
for param := range extraOptions.AsMap().Get(kubeadm.Kubeadm) {
541546
if !pkgutil.ContainsString(kubeadm.KubeadmExtraArgsWhitelist[kubeadm.KubeadmCmdParam], param) &&

Diff for: pkg/minikube/constants/constants.go

+2
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ const (
141141
MinimumMemorySize = "1024mb"
142142
// DefaultCPUS is the default number of cpus of a host
143143
DefaultCPUS = 2
144+
// MinimumCPUS is the minimum number of cpus of a host
145+
MinimumCPUS = 2
144146
// DefaultDiskSize is the default disk image size, in megabytes
145147
DefaultDiskSize = "20000mb"
146148
// MinimumDiskSize is the minimum disk image size, in megabytes

0 commit comments

Comments
 (0)