Skip to content

Commit ef1a48f

Browse files
authored
Merge pull request #8863 from medyagh/dont_metric
UI: suggest to enable `metric-server` for full feature dashboard addon.
2 parents f8406b6 + 1f5fc25 commit ef1a48f

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

Diff for: cmd/minikube/cmd/config/enable.go

+12-5
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@ limitations under the License.
1717
package config
1818

1919
import (
20+
"fmt"
21+
2022
"github.com/spf13/cobra"
2123
"k8s.io/minikube/pkg/addons"
24+
"k8s.io/minikube/pkg/minikube/constants"
2225
"k8s.io/minikube/pkg/minikube/exit"
2326
"k8s.io/minikube/pkg/minikube/out"
2427
)
@@ -42,12 +45,16 @@ var addonsEnableCmd = &cobra.Command{
4245
exit.WithError("enable failed", err)
4346
}
4447
if addon == "dashboard" {
45-
out.T(out.Waiting, "Some dashboard features require the 'metrics-server' add-on")
46-
err = addons.SetAndSave(ClusterFlagValue(), "metrics-server", "true")
47-
if err != nil {
48-
exit.WithError("enable failed", err)
48+
tipProfileArg := ""
49+
if ClusterFlagValue() != constants.DefaultClusterName {
50+
tipProfileArg = fmt.Sprintf(" -p %s", ClusterFlagValue())
4951
}
50-
out.T(out.AddonEnable, "The 'metrics-server' add-on was enabled automatically")
52+
out.T(out.Tip, `Some dashboard features require the metrics-server addon. To enable all features please run:
53+
54+
minikube{{.profileArg}} addons enable metrics-server
55+
56+
`, out.V{"profileArg": tipProfileArg})
57+
5158
}
5259

5360
out.T(out.AddonEnable, "The '{{.addonName}}' addon is enabled", out.V{"addonName": addon})

0 commit comments

Comments
 (0)