Skip to content

Commit f22b29f

Browse files
authored
Merge pull request #19545 from RamBITS-AI/merge_nvidia-gpu-device-plugin__and__nvidia_device_plugin
Merge nvidia-gpu-device-plugin and nvidia-device-plugin.
2 parents d5c439e + 1db9a87 commit f22b29f

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

pkg/addons/addons.go

+4
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ func preStartMessages(name, value string) {
104104
out.Styled(style.Warning, "The ambassador addon has stopped working as of v1.23.0, for more details visit: https://github.com/datawire/ambassador-operator/issues/73")
105105
case "olm":
106106
out.Styled(style.Warning, "The OLM addon has stopped working, for more details visit: https://github.com/operator-framework/operator-lifecycle-manager/issues/2534")
107+
case "nvidia-gpu-device-plugin":
108+
out.Styled(style.Warning, "The nvidia-gpu-device-plugin addon is deprecated and it's functionality is merged inside of nvidia-device-plugin addon. It will be removed in a future release. Please use the nvidia-device-plugin addon instead. For more details, visit: https://github.com/kubernetes/minikube/issues/19114.")
107109
}
108110
}
109111

@@ -163,6 +165,8 @@ func Deprecations(name string) (bool, string, string) {
163165
return true, "metrics-server", "using metrics-server addon, heapster is deprecated"
164166
case "efk":
165167
return true, "", "The current images used in the efk addon contain Log4j vulnerabilities, the addon will be disabled until images are updated, see: https://github.com/kubernetes/minikube/issues/15280"
168+
case "nvidia-gpu-device-plugin":
169+
return true, "nvidia-device-plugin", "The nvidia-gpu-device-plugin addon is deprecated and it's functionality is merged inside of nvidia-device-plugin addon. It will be removed in a future release. Please use the nvidia-device-plugin addon instead. For more details, visit: https://github.com/kubernetes/minikube/issues/19114."
166170
}
167171
return false, "", ""
168172
}

pkg/addons/config.go

+1
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ var Addons = []*Addon{
126126
callbacks: []setFn{EnableOrDisableAddon},
127127
},
128128
{
129+
// The nvidia-gpu-device-plugin addon is deprecated and it's functionality is merged inside of nvidia-device-plugin addon.
129130
name: "nvidia-gpu-device-plugin",
130131
set: SetBool,
131132
validations: []setFn{isKVMDriverForNVIDIA},

site/content/en/docs/tutorials/nvidia.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,10 @@ host to the minikube VM. Doing so has a few prerequisites:
113113

114114
If this succeeded, run the following commands:
115115
```shell
116-
minikube addons enable nvidia-gpu-device-plugin
116+
minikube addons enable nvidia-device-plugin
117117
minikube addons enable nvidia-driver-installer
118118
```
119+
NOTE: `nvidia-gpu-device-plugin` addon has been deprecated and it's functionality is merged inside of `nvidia-device-plugin` addon.
119120

120121
This will install the NVIDIA driver (that works for GeForce/Quadro cards)
121122
on the VM.

0 commit comments

Comments
 (0)