Skip to content

Commit f981dd1

Browse files
spowelljrspowelljr
authored
Merge pull request #15081 from klaases/warn1
Warn if addon has no associated Github username
2 parents 2cb8652 + 4cd9394 commit f981dd1

File tree

10 files changed

+22
-10
lines changed

10 files changed

+22
-10
lines changed

‎cmd/minikube/cmd/config/enable.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,14 @@ var addonsEnableCmd = &cobra.Command{
6363
You can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS`,
6464
out.V{"addon": addon, "maintainer": maintainer})
6565
} else {
66-
out.Styled(style.Warning, `{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.`,
66+
out.Styled(style.Warning, `{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.`,
6767
out.V{"addon": addon})
6868
if addonBundle.VerifiedMaintainer != "" {
6969
out.Styled(style.Tip, `{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.`,
7070
out.V{"addon": addon, "maintainer": maintainer, "verifiedMaintainer": addonBundle.VerifiedMaintainer})
71+
} else {
72+
out.Styled(style.Warning, `{{.addon}} does not currently have an associated maintainer.`,
73+
out.V{"addon": addon})
7174
}
7275
}
7376
}

‎translations/de.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1035,7 +1035,8 @@
10351035
"zsh completion.": "",
10361036
"{{ .name }}: Suggestion: {{ .suggestion}}": "{{ .name }}: Vorschlag: {{ .suggestion}}",
10371037
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "{{.Driver}} verwendet derzeit den {{.StorageDriver}} Storage Treiber, erwäge zu overlay2 zu wechseln für bessere Performance",
1038-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
1038+
"{{.addon}} does not currently have an associated maintainer.": "",
1039+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
10391040
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
10401041
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
10411042
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "{{.count}} Node{{if gt .count 1}}s{{end}} angehalten.",

‎translations/es.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1030,7 +1030,8 @@
10301030
"{{ .name }}: Suggestion: {{ .suggestion}}": "{{ .name }}: Sugerencia: {{ .suggestion}}",
10311031
"{{ .name }}: {{ .rejection }}": "{{ .name }}: {{ .rejection }}",
10321032
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
1033-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
1033+
"{{.addon}} does not currently have an associated maintainer.": "",
1034+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
10341035
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
10351036
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
10361037
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "",

‎translations/fr.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1008,7 +1008,8 @@
10081008
"{{ .name }}: Suggestion: {{ .suggestion}}": "{{ .name }}: Suggestion: {{ .suggestion}}",
10091009
"{{ .name }}: {{ .rejection }}": "{{ .name }} : {{ .rejection }}",
10101010
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "{{.Driver}} utilise actuellement le pilote de stockage {{.StorageDriver}}, envisagez de passer à overlay2 pour de meilleures performances",
1011-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "{{.addon}} est un module complémentaire tiers et non maintenu ou vérifié par les mainteneurs de minikube, activez-le à vos risques et périls.",
1011+
"{{.addon}} does not currently have an associated maintainer.": "",
1012+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "{{.addon}} est un module complémentaire tiers et non maintenu ou vérifié par les mainteneurs de minikube, activez-le à vos risques et périls.",
10121013
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "{{.addon}} est un addon maintenu par {{.maintainer}}. Pour toute question, contactez minikube sur GitHub.\nVous pouvez consulter la liste des mainteneurs de minikube sur : https://github.com/kubernetes/minikube/blob/master/OWNERS",
10131014
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "{{.addon}} est maintenu par {{.maintainer}} pour tout problème, contactez {{.verifiedMaintainer}} sur GitHub.",
10141015
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "{{.count}} nœud{{if gt .count 1}}s{{end}} arrêté{{if gt .count 1}}s{{end}}.",

‎translations/ja.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -967,7 +967,8 @@
967967
"zsh completion.": "zsh のコマンド補完です。",
968968
"{{ .name }}: Suggestion: {{ .suggestion}}": "{{ .name }}: 提案: {{ .suggestion}}",
969969
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "{{.Driver}} は現在 {{.StorageDriver}} ストレージドライバーを使用しています。性能向上のため overlay2 への切替を検討してください",
970-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
970+
"{{.addon}} does not currently have an associated maintainer.": "",
971+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
971972
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
972973
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
973974
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "{{.count}} 台のノードが停止しました。",

‎translations/ko.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1038,7 +1038,8 @@
10381038
"zsh completion.": "",
10391039
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
10401040
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
1041-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
1041+
"{{.addon}} does not currently have an associated maintainer.": "",
1042+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
10421043
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
10431044
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
10441045
"{{.count}} nodes stopped.": "{{.count}}개의 노드가 중지되었습니다.",

‎translations/pl.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1044,7 +1044,8 @@
10441044
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
10451045
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
10461046
"{{.addonName}} was successfully enabled": "{{.addonName}} został aktywowany pomyślnie",
1047-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
1047+
"{{.addon}} does not currently have an associated maintainer.": "",
1048+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
10481049
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
10491050
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
10501051
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "",

‎translations/ru.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,8 @@
961961
"zsh completion.": "",
962962
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
963963
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
964-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
964+
"{{.addon}} does not currently have an associated maintainer.": "",
965+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
965966
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
966967
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
967968
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "Остановлено узлов: {{.count}}.",

‎translations/strings.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,8 @@
961961
"zsh completion.": "",
962962
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
963963
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
964-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
964+
"{{.addon}} does not currently have an associated maintainer.": "",
965+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
965966
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
966967
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
967968
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "",

‎translations/zh-CN.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1154,7 +1154,8 @@
11541154
"zsh completion.": "",
11551155
"{{ .name }}: Suggestion: {{ .suggestion}}": "",
11561156
"{{.Driver}} is currently using the {{.StorageDriver}} storage driver, consider switching to overlay2 for better performance": "",
1157-
"{{.addon}} is a 3rd party addon and not maintained or verified by minikube maintainers, enable at your own risk.": "",
1157+
"{{.addon}} does not currently have an associated maintainer.": "",
1158+
"{{.addon}} is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.": "",
11581159
"{{.addon}} is an addon maintained by {{.maintainer}}. For any concerns contact minikube on GitHub.\nYou can view the list of minikube maintainers at: https://github.com/kubernetes/minikube/blob/master/OWNERS": "",
11591160
"{{.addon}} is maintained by {{.maintainer}} for any concerns contact {{.verifiedMaintainer}} on GitHub.": "",
11601161
"{{.count}} node{{if gt .count 1}}s{{end}} stopped.": "",

0 commit comments

Comments
 (0)