Skip to content

minikube start --image-repository=xxx does not work with ports in URL #11579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmpe opened this issue Jun 4, 2021 · 2 comments · Fixed by #11585
Closed

minikube start --image-repository=xxx does not work with ports in URL #11579

dmpe opened this issue Jun 4, 2021 · 2 comments · Fixed by #11585
Assignees
Labels
kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@dmpe
Copy link
Contributor

dmpe commented Jun 4, 2021

Hi there,
I have identified an issue whereby I consider this to be a regression, because it was certainly working in some of the past minikube releases (a number of releases back, cannot find this now easily).

With https://github.com/kubernetes/minikube/blob/v1.19.0/cmd/minikube/cmd/start_test.go minikube 1.19 there is now a TestValidateImageRepository. This checks for different formatting of the registry URL.

Our nexus3 docker registry has this format: nexus.devops.firm.com:6666. We use this type of URL everywhere else successfully and no known issues have been observed with this format. However, we started to transition to using nexus registry "everywhere", i.e. also for minikube and when installing minikube from scratch with following:

Steps to reproduce the issue:

  1. minikube start --image-repository=nexus.devops.firm.com:6666 --driver=none --delete-on-failure=true

We get this error:

 minikube v1.20.0 on Centos 7.9.2009
* Using the none driver based on user configuration
  - The --image-repository flag your provided contains Scheme: nexus.devops.firm.com, it will be as a domian, removed automatically
* Using image repository

I.e. 6666 is stripped, hence the internal URL is ignored and hence it falls back to the assumption that VM in question has access to the internet (which in our case does not and hence we found out about this).

Full output of failed command:

Cannot post because a lot of private details (username, etc.). Sorry. But I am willing to test previews/rc/beta versions and maybe even contribute :)

@dmpe
Copy link
Contributor Author

dmpe commented Jun 5, 2021

/assign

@RA489
Copy link

RA489 commented Jun 7, 2021

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Jun 7, 2021
@spowelljr spowelljr added kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed co/none-driver kind/support Categorizes issue or PR as a support question. labels Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants