Skip to content

proposal: add host OS addon hooks #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
woodcockjosh opened this issue Sep 30, 2019 · 5 comments
Closed

proposal: add host OS addon hooks #5498

woodcockjosh opened this issue Sep 30, 2019 · 5 comments
Labels
kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@woodcockjosh
Copy link
Contributor

woodcockjosh commented Sep 30, 2019

In order to provide a richer and more simplified development experience, some addons may be better equipped if they can be integrated with capabilities that run on the Host OS.

The hooks would be ran as part of the addon lifecycle:

  • pre enable
  • post enable
  • pre disable
  • post disable

Example use cases:

  • Running a service on the Host OS that updates resolver configuration files or the /etc/hosts file with ingress resources in a cluster so that DNS can be resolved. This would utilize the post-enable hook which would start service on the host OS and a pre-disable hook which would stop the service on the host OS. See proposal: Enable host OS dns resolution of cluster ingress host names #5494
  • Richer integration with 3rd part tools that run on the Host OS like skaffold and integrated development environments like intelliJ
  • Creation of an integrated debuging client that allows debugging of k8s resources with a step-by-step debugger like xdebug

Options

  • run as sudo: Whether or not to run the hook with sudo permissions. This would require the user to enter their sudo password after running minikube addon enable

Other considerations

These hooks could also open the door for contributors to start to create "external addons" which would be an addon that can be used with minikube but not part of the minikube codebase. Very similar to how helm enables you to create plugins which are not a part of helm through the use of hooks.

@tstromberg tstromberg added the triage/discuss Items for discussion label Sep 30, 2019
@woodcockjosh
Copy link
Contributor Author

#5505

@woodcockjosh
Copy link
Contributor Author

woodcockjosh commented Oct 1, 2019

Use case addon for this host OS hook: #5507

@tstromberg tstromberg added kind/proposal proposals priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 2, 2019
@tstromberg tstromberg removed the kind/proposal proposals label Nov 11, 2019
@priyawadhwa priyawadhwa added the kind/design Categorizes issue or PR as related to design. label Nov 11, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2020
@tstromberg
Copy link
Contributor

Closing as this proposal appears to be on hold.

@tstromberg tstromberg removed the triage/discuss Items for discussion label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants