"cache add" command: improve error message for not existing image.

[medyagh]

PS C:\Users\jenkins> minikube cache add doesnt_exist_thing:haha
E0910 18:30:13.540553    3980 cache.go:63] save image to file "doesnt_exist_thing:haha" -> "C:\\Users\\jenkins\\.minikube\\cache\\images\\doesnt_exist_thing_haha" failed: nil image for doesnt_exist_thing:haha: GET https://index.docker.io/v2/library/doesnt_exist_thing/manifests/haha: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:library/doesnt_exist_thing Type:repository]]

X Exiting due to MK_CACHE_LOAD: save to dir: caching images: caching image "C:\\Users\\jenkins\\.minikube\\cache\\images\\doesnt_exist_thing_haha": nil image for doesnt_exist_thing:haha: GET https://index.docker.io/v2/library/doesnt_exist_thing/manifests/haha: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:library/doesnt_exist_thing Type:repository]]
*
* If the above advice does not help, please let us know:
  - https://github.com/kubernetes/minikube/issues/new/choose

[Evalle]

I can try to help with that
/assign

[Evalle]

Hey @medyagh what about something like that:

Before:

PS C:\Users\jenkins> minikube cache add doesnt_exist_thing:haha
E0910 18:30:13.540553    3980 cache.go:63] save image to file "doesnt_exist_thing:haha" -> "C:\\Users\\jenkins\\.minikube\\cache\\images\\doesnt_exist_thing_haha" failed: nil image for doesnt_exist_thing:haha: GET https://index.docker.io/v2/library/doesnt_exist_thing/manifests/haha: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:library/doesnt_exist_thing Type:repository]]

X Exiting due to MK_CACHE_LOAD: save to dir: caching images: caching image "C:\\Users\\jenkins\\.minikube\\cache\\images\\doesnt_exist_thing_haha": nil image for doesnt_exist_thing:haha: GET https://index.docker.io/v2/library/doesnt_exist_thing/manifests/haha: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:library/doesnt_exist_thing Type:repository]]
*
* If the above advice does not help, please let us know:
  - https://github.com/kubernetes/minikube/issues/new/choose

After:

❯ ./out/minikube  cache add doesnt_exist_thing:haha
E0922 15:42:36.984485   75391 cache.go:63] save image to file "doesnt_exist_thing:haha" -> "/Users/i356129/.minikube/cache/images/doesnt_exist_thing_haha" failed:
The image you're trying to add to the cache doesn't exist locally on your machine: try to build or to pull it first.

❌  Exiting due to MK_CACHE_LOAD: save to dir: caching images: caching image "/Users/i356129/.minikube/cache/images/doesnt_exist_thing_haha": nil image for doesnt_exist_thing:haha: GET https://index.docker.io/v2/library/doesnt_exist_thing/manifests/haha: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:library/doesnt_exist_thing Type:repository]]

😿  If the above advice does not help, please let us know:
👉  https://github.com/kubernetes/minikube/issues/new/choose

[tstromberg]

@Evalle - sounds good to me.

[medyagh]

@Evalle I have not heared from you, are u still doing this ?

[tripolkaandrey]

@medyagh do you mind if assigned myself and tried it?

[Evalle]

@tripolkaandrey feel free to work on it!
/assign @tripolkaandrey

[tripolkaandrey]

@Evalle okay. Thank you for assigning me

[spowelljr]

Thanks for taking the issue @tripolkaandrey!

[tripolkaandrey]

@spowelljr I am glad to help