Fix golint errors

Add mount package to hack/.golint_failures to ignore stuttering errors.

Author: codenrhoden

hack/.golint_failures

@@ -1 +1,2 @@
 # Apart from this line, only trailing comments are supported
+mount

hack/verify-golint.sh

@@ -46,7 +46,6 @@ unset IFS
 errors=()
 not_failing=()
 for p in "${all_packages[@]}"; do
-  failing_packages="${failing_packages:-}"
   # Run golint on package/*.go file explicitly to validate all go files
   # and not just the ones for the current platform. This also will ensure that
   # _test.go files are linted.
@@ -90,26 +89,26 @@ else
   exit 1
 fi
 
-# if [[ ${#not_failing[@]} -gt 0 ]]; then
-#   {
-#     echo "Some packages in hack/.golint_failures are passing golint. Please remove them."
-#     echo
-#     for p in "${not_failing[@]}"; do
-#       echo "  $p"
-#     done
-#     echo
-#   } >&2
-#   exit 1
-# fi
-#
-# if [[ ${#gone[@]} -gt 0 ]]; then
-#   {
-#     echo "Some packages in hack/.golint_failures do not exist anymore. Please remove them."
-#     echo
-#     for p in "${gone[@]}"; do
-#       echo "  $p"
-#     done
-#     echo
-#   } >&2
-#   exit 1
-# fi
+if [[ ${#not_failing[@]} -gt 0 ]]; then
+  {
+    echo "Some packages in hack/.golint_failures are passing golint. Please remove them."
+    echo
+    for p in "${not_failing[@]}"; do
+      echo "  $p"
+    done
+    echo
+  } >&2
+  exit 1
+fi
+
+if [[ ${#gone[@]} -gt 0 ]]; then
+  {
+    echo "Some packages in hack/.golint_failures do not exist anymore. Please remove them."
+    echo
+    for p in "${gone[@]}"; do
+      echo "  $p"
+    done
+    echo
+  } >&2
+  exit 1
+fi

mount/fake_mounter.go

@@ -36,6 +36,7 @@ type FakeMounter struct {
 	UnmountFunc UnmountFunc
 }
 
+// UnmountFunc is a function callback to be executed during the Unmount() call.
 type UnmountFunc func(path string) error
 
 var _ Interface = &FakeMounter{}
@@ -55,6 +56,8 @@ type FakeAction struct {
 	FSType string // applies only to "mount" actions
 }
 
+// NewFakeMounter returns a FakeMounter struct that implements Interface and is
+// suitable for testing purposes.
 func NewFakeMounter(mps []MountPoint) *FakeMounter {
 	return &FakeMounter{
 		MountPoints: mps,

mount/mount_helper_windows.go

@@ -70,6 +70,9 @@ func IsCorruptedMnt(err error) bool {
 	return false
 }
 
+// NormalizeWindowsPath makes sure the given path is a valid path on Windows
+// systems by making sure all instances of `/` are replaced with `\\`, and the
+// path beings with `c:`
 func NormalizeWindowsPath(path string) string {
 	normalizedPath := strings.Replace(path, "/", "\\", -1)
 	if strings.HasPrefix(normalizedPath, "\\") {