Add prefetch rows tweakable #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbj
reviewed
Jun 19, 2021
src/connection.rs
Outdated
| /// By default, a maximum of 2 rows are returned when the query is first | ||
| /// executed. To modify this, use `StmtParam::PrefetchRows(u32)` to customize | ||
| /// it. For more information on the difference between this and `FetchArraySize`, | ||
| /// see [this writeup](https://blog.dbi-services.com/arraysize-or-rowprefetch-in-sqlplus/). |
There was a problem hiding this comment.
Another reference is https://oracle.github.io/node-oracledb/doc/api.html#rowfetching
src/statement.rs
Outdated
| @@ -59,6 +59,17 @@ pub enum StmtParam { | |||
| /// `StmtParam::FetchArraySize(1)`. | |||
| FetchArraySize(u32), | |||
|
|
|||
| /// The number of rows that will be prefetched by the Oracle Client | |||
| /// ibrary when a query is executed. The default value is | |||
|
@daviessm Thanks for the PR and sorry for not replying so long. I don't merge this PR because the new variant |
|
I'm happy either way - if it's easier for you to do it yourself, go for it! |
|
I did it by 7ec5577, which closes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #39