Skip to content

Commit acdee29

Browse files
committed
don't write 'dummy' results when no tests ran
cucumber#1326
1 parent 1eb7d39 commit acdee29

File tree

2 files changed

+0
-29
lines changed

2 files changed

+0
-29
lines changed

core/src/main/java/cucumber/runtime/formatter/JUnitFormatter.java

-13
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,6 @@ private void finishReport() {
142142
rootElement.setAttribute("failures", String.valueOf(rootElement.getElementsByTagName("failure").getLength()));
143143
rootElement.setAttribute("skipped", String.valueOf(rootElement.getElementsByTagName("skipped").getLength()));
144144
rootElement.setAttribute("time", sumTimes(rootElement.getElementsByTagName("testcase")));
145-
if (rootElement.getElementsByTagName("testcase").getLength() == 0) {
146-
addDummyTestCase(); // to avoid failed Jenkins jobs
147-
}
148145
TransformerFactory transfac = TransformerFactory.newInstance();
149146
Transformer trans = transfac.newTransformer();
150147
trans.setOutputProperty(OutputKeys.INDENT, "yes");
@@ -157,16 +154,6 @@ private void finishReport() {
157154
}
158155
}
159156

160-
private void addDummyTestCase() {
161-
Element dummy = doc.createElement("testcase");
162-
dummy.setAttribute("classname", "dummy");
163-
dummy.setAttribute("name", "dummy");
164-
rootElement.appendChild(dummy);
165-
Element skipped = doc.createElement("skipped");
166-
skipped.setAttribute("message", "No features found");
167-
dummy.appendChild(skipped);
168-
}
169-
170157
private String sumTimes(NodeList testCaseNodes) {
171158
double totalDurationSecondsForAllTimes = 0.0d;
172159
for( int i = 0; i < testCaseNodes.getLength(); i++ ) {

core/src/test/java/cucumber/runtime/formatter/JUnitFormatterTest.java

-16
Original file line numberDiff line numberDiff line change
@@ -499,22 +499,6 @@ public void should_format_scenario_outlines_with_arguments_in_name() throws Thro
499499
assertXmlEqual(expected, formatterOutput);
500500
}
501501

502-
@Test
503-
public void should_add_dummy_testcase_if_no_scenarios_are_run_to_aviod_failed_jenkins_jobs() throws Throwable {
504-
CucumberFeature feature = TestHelper.feature("path/test.feature",
505-
"Feature: feature name\n");
506-
507-
String formatterOutput = runFeatureWithJUnitFormatter(feature);
508-
509-
String expected = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n" +
510-
"<testsuite failures=\"0\" name=\"cucumber.runtime.formatter.JUnitFormatter\" skipped=\"0\" time=\"0\">\n" +
511-
" <testcase classname=\"dummy\" name=\"dummy\">\n" +
512-
" <skipped message=\"No features found\" />\n" +
513-
" </testcase>\n" +
514-
"</testsuite>\n";
515-
assertXmlEqual(expected, formatterOutput);
516-
}
517-
518502
private File runFeaturesWithJunitFormatter(final List<String> featurePaths) throws IOException {
519503
return runFeaturesWithJunitFormatter(featurePaths, false);
520504
}

0 commit comments

Comments
 (0)