Skip to content

Commit 54ee0e3

Browse files
committed
Merge pull request oracle#116 in OKE/oci-cloud-controller-manager from task/OKE-13164 to internal
* commit '7158d3aabcbefc5c6da0d29081a49f8cd8644fc4': JIRA:task/OKE-13164 :: Addressing comments. JIRA:task/OKE-13164 :: Addressing comments. JIRA:task/OKE-13164 :: Addressing comments. JIRA:task/OKE-13164 :: Addressing comments. JIRA:task/OKE-13164 :: Adding OPC request id
2 parents 33cc873 + 7158d3a commit 54ee0e3

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

pkg/oci/client/block_storage.go

+11-3
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,14 @@ func (c *client) CreateVolume(ctx context.Context, details core.CreateVolumeDeta
112112
RequestMetadata: c.requestMetadata})
113113
incRequestCounter(err, createVerb, volumeResource)
114114

115-
if err != nil {
115+
if err == nil {
116+
logger := c.logger.With("AvailabilityDomain", *(details.AvailabilityDomain),
117+
"CompartmentId", *(details.CompartmentId), "VolumeName", *(details.DisplayName),
118+
"OpcRequestId",*(resp.OpcRequestId))
119+
logger.Info("OPC Request ID recorded while creating volume.")
120+
} else {
116121
return nil, errors.WithStack(err)
117122
}
118-
119123
return &resp.Volume, nil
120124
}
121125

@@ -146,7 +150,11 @@ func (c *client) GetVolumesByName(ctx context.Context, volumeName, compartmentID
146150
CompartmentId: &compartmentID,
147151
DisplayName: &volumeName,
148152
RequestMetadata: c.requestMetadata})
149-
if err != nil {
153+
if err == nil {
154+
logger := c.logger.With("VolumeName", volumeName, "CompartmentID", compartmentID,
155+
"OpcRequestId",*(listVolumeResponse.OpcRequestId))
156+
logger.Info("OPC Request ID recorded while fetching volumes by name.")
157+
} else {
150158
return nil, err
151159
}
152160
return listVolumeResponse.Items, nil

0 commit comments

Comments
 (0)