Skip to content

Commit 3f8ae15

Browse files
mobinanooriimobinanoori018
and
mobinanoori018
authored
delete unused context in body_limit.go (#2483)
* delete unused context in body_limit.go --------- Co-authored-by: mobinanoori018 <[email protected]>
1 parent 4598a4a commit 3f8ae15

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

middleware/body_limit.go

+4-6
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,8 @@ type (
2323

2424
limitedReader struct {
2525
BodyLimitConfig
26-
reader io.ReadCloser
27-
read int64
28-
context echo.Context
26+
reader io.ReadCloser
27+
read int64
2928
}
3029
)
3130

@@ -80,7 +79,7 @@ func BodyLimitWithConfig(config BodyLimitConfig) echo.MiddlewareFunc {
8079

8180
// Based on content read
8281
r := pool.Get().(*limitedReader)
83-
r.Reset(req.Body, c)
82+
r.Reset(req.Body)
8483
defer pool.Put(r)
8584
req.Body = r
8685

@@ -102,9 +101,8 @@ func (r *limitedReader) Close() error {
102101
return r.reader.Close()
103102
}
104103

105-
func (r *limitedReader) Reset(reader io.ReadCloser, context echo.Context) {
104+
func (r *limitedReader) Reset(reader io.ReadCloser) {
106105
r.reader = reader
107-
r.context = context
108106
r.read = 0
109107
}
110108

middleware/body_limit_test.go

+1-5
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ func TestBodyLimit(t *testing.T) {
5656

5757
func TestBodyLimitReader(t *testing.T) {
5858
hw := []byte("Hello, World!")
59-
e := echo.New()
60-
req := httptest.NewRequest(http.MethodPost, "/", bytes.NewReader(hw))
61-
rec := httptest.NewRecorder()
6259

6360
config := BodyLimitConfig{
6461
Skipper: DefaultSkipper,
@@ -68,7 +65,6 @@ func TestBodyLimitReader(t *testing.T) {
6865
reader := &limitedReader{
6966
BodyLimitConfig: config,
7067
reader: io.NopCloser(bytes.NewReader(hw)),
71-
context: e.NewContext(req, rec),
7268
}
7369

7470
// read all should return ErrStatusRequestEntityTooLarge
@@ -78,7 +74,7 @@ func TestBodyLimitReader(t *testing.T) {
7874

7975
// reset reader and read two bytes must succeed
8076
bt := make([]byte, 2)
81-
reader.Reset(io.NopCloser(bytes.NewReader(hw)), e.NewContext(req, rec))
77+
reader.Reset(io.NopCloser(bytes.NewReader(hw)))
8278
n, err := reader.Read(bt)
8379
assert.Equal(t, 2, n)
8480
assert.Equal(t, nil, err)

0 commit comments

Comments
 (0)