[BUILD] Build break using protoc 3.14 (open-telemetry#3211)

marcalff · web-flow · commit 1cbea09cb0c1 · 2024-12-17T18:07:01.000+01:00
diff --git a/exporters/otlp/test/otlp_recordable_test.cc b/exporters/otlp/test/otlp_recordable_test.cc
@@ -136,7 +136,8 @@ TEST(OtlpRecordable, SetInstrumentationScopeWithAttributes)
 
   ASSERT_EQ(proto_instr_libr.attributes_size(), 1);
   const auto &proto_attributes = proto_instr_libr.attributes(0);
-  ASSERT_TRUE(proto_attributes.value().has_string_value());
+  // Requires protoc 3.15.0
+  // ASSERT_TRUE(proto_attributes.value().has_string_value());
   EXPECT_EQ("test_key", proto_attributes.key());
   EXPECT_EQ("test_value", proto_attributes.value().string_value());
 }

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,8 @@ TEST(OtlpRecordable, SetInstrumentationScopeWithAttributes)`
`136`	`136`
`137`	`137`	`ASSERT_EQ(proto_instr_libr.attributes_size(), 1);`
`138`	`138`	`const auto &proto_attributes = proto_instr_libr.attributes(0);`
`139`		`- ASSERT_TRUE(proto_attributes.value().has_string_value());`
	`139`	`+ // Requires protoc 3.15.0`
	`140`	`+ // ASSERT_TRUE(proto_attributes.value().has_string_value());`
`140`	`141`	`EXPECT_EQ("test_key", proto_attributes.key());`
`141`	`142`	`EXPECT_EQ("test_value", proto_attributes.value().string_value());`
`142`	`143`	`}`